Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test amalgamated build on Windows #969

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Test amalgamated build on Windows #969

wants to merge 1 commit into from
+12 −1

Conversation

saghul
Copy link
Contributor

@saghul saghul commented Mar 11, 2025

No description provided.

@saghul saghul marked this pull request as draft March 11, 2025 20:03
@saghul saghul force-pushed the win-test-amalgam branch from e413c51 to c1afb7a Compare March 11, 2025 20:20
@saghul
Copy link
Contributor Author

saghul commented Mar 11, 2025

Fun!

quickjs-amalgam.c
quickjs-amalgam.c(759): error C2059: syntax error: 'for'
quickjs-amalgam.c(759): error C2143: syntax error: missing '{' before '!='
quickjs-amalgam.c(759): error C2059: syntax error: '!='
quickjs-amalgam.c(759): error C2223: left of '->next' must point to struct/union
quickjs-amalgam.c(759): error C2059: syntax error: ')'
quickjs-amalgam.c(763): error C2143: syntax error: missing ';' before 'for'
quickjs-amalgam.c(763): error C2143: syntax error: missing '{' before '!='
quickjs-amalgam.c(763): error C2059: syntax error: '!='
quickjs-amalgam.c(765): error C2374: 'el': redefinition; multiple initialization
quickjs-amalgam.c(759): note: see declaration of 'el'
quickjs-amalgam.c(765): error C2065: 'el1': undeclared identifier
quickjs-amalgam.c(765): error C2223: left of '->next' must point to struct/union
quickjs-amalgam.c(765): error C2059: syntax error: ')'
quickjs-amalgam.c(769): error C2143: syntax error: missing ';' before 'for'
quickjs-amalgam.c(769): error C2143: syntax error: missing '{' before '!='
quickjs-amalgam.c(769): error C2059: syntax error: '!='
quickjs-amalgam.c(769): error C2374: 'el': redefinition; multiple initialization
quickjs-amalgam.c(759): note: see declaration of 'el'
quickjs-amalgam.c(769): error C2223: left of '->prev' must point to struct/union
quickjs-amalgam.c(769): error C2059: syntax error: ')'
quickjs-amalgam.c(773): error C2143: syntax error: missing ';' before 'for'
quickjs-amalgam.c(773): error C2143: syntax error: missing '{' before '!='
quickjs-amalgam.c(773): error C2059: syntax error: '!='
quickjs-amalgam.c(775): error C2374: 'el': redefinition; multiple initialization
quickjs-amalgam.c(759): note: see declaration of 'el'
quickjs-amalgam.c(775): error C2374: 'el1': redefinition; multiple initialization
quickjs-amalgam.c(765): note: see declaration of 'el1'
quickjs-amalgam.c(775): error C2223: left of '->prev' must point to struct/union
quickjs-amalgam.c(775): error C2059: syntax error: ')'
quickjs-amalgam.c(839): error C2143: syntax error: missing ';' before 'type'
quickjs-amalgam.c(7515): error C2059: syntax error: 'string'
quickjs-amalgam.c(15210): error C2044: illegal continue
quickjs-amalgam.c(15212): error C2044: illegal continue
quickjs-amalgam.c(26511): error C2146: syntax error: missing ')' before identifier 'binary_op'
quickjs-amalgam.c(26519): error C2065: 'slow_call': undeclared identifier
quickjs-amalgam.c(26499): error C2051: case expression not constant
quickjs-amalgam.c(28667): error C2065: 'op': undeclared identifier
quickjs-amalgam.c(28669): error C2065: 'op': undeclared identifier
quickjs-amalgam.c(28669): error C2065: 'op': undeclared identifier
quickjs-amalgam.c(28667): error C2057: expected constant expression
quickjs-amalgam.c(28667): error C2466: cannot allocate an array of constant size 0
quickjs-amalgam.c(28667): error C2373: 'opcode_info': redefinition; different type modifiers
quickjs-amalgam.c(28279): note: see declaration of 'opcode_info'
quickjs-amalgam.c(28667): error C2054: expected '(' to follow 'opcode_info'
quickjs-amalgam.c(28671): error C2085: 'next_token': not in formal parameter list
quickjs-amalgam.c(28673): error C2085: 'free_token': not in formal parameter list
quickjs-amalgam.c(28674): error C2143: syntax error: missing ';' before '{'
quickjs-amalgam.c(36736): error C2059: syntax error: 'do'
quickjs-amalgam.c(36740): warning C5100: __VA_ARGS__ is reserved for use in variadic macros
quickjs-amalgam.c(36740): note: in expansion of macro '__VA_ARGS__'
quickjs-amalgam.c(36742): error C2059: syntax error: 'while'
quickjs-amalgam.c(38209): error C2059: syntax error: ';'
quickjs-amalgam.c(38339): error C2059: syntax error: ';'
quickjs-amalgam.c(38411): error C2059: syntax error: ';'
quickjs-amalgam.c(38608): error C2059: syntax error: '.'
quickjs-amalgam.c(38732): error C2059: syntax error: '.'
quickjs-amalgam.c(41800): error C2059: syntax error: ';'
quickjs-amalgam.c(43601): error C2059: syntax error: '.'
quickjs-amalgam.c(43602): error C2059: syntax error: '.'
quickjs-amalgam.c(43671): error C2059: syntax error: '.'
quickjs-amalgam.c(43672): error C2059: syntax error: '.'
quickjs-amalgam.c(43683): error C2047: illegal default
quickjs-amalgam.c(43689): error C2059: syntax error: 'if'
quickjs-amalgam.c(43692): error C2143: syntax error: missing ')' before '&'
quickjs-amalgam.c(43692): error C2143: syntax error: missing '{' before '&'
quickjs-amalgam.c(43692): error C2059: syntax error: '&'
quickjs-amalgam.c(43692): error C2059: syntax error: ')'
quickjs-amalgam.c(43694): error C2143: syntax error: missing ')' before '->'
quickjs-amalgam.c(43694): error C2143: syntax error: missing '{' before '->'
quickjs-amalgam.c(43694): error C2059: syntax error: '->'
quickjs-amalgam.c(43694): error C2059: syntax error: ')'
quickjs-amalgam.c(43695): error C2059: syntax error: 'return'
quickjs-amalgam.c(43696): error C2143: syntax error: missing '{' before ':'
quickjs-amalgam.c(43696): error C2059: syntax error: ':'
quickjs-amalgam.c(43698): error C2059: syntax error: 'return'
quickjs-amalgam.c(43699): error C2059: syntax error: '}'
quickjs-amalgam.c(44607): error C2059: syntax error: '.'
quickjs-amalgam.c(44608): error C2059: syntax error: '.'
quickjs-amalgam.c(44622): error C2047: illegal default
quickjs-amalgam.c(44639): error C2059: syntax error: 'return'
quickjs-amalgam.c(44640): error C2059: syntax error: '}'
quickjs-amalgam.c(58060): error C2044: illegal continue
quickjs-amalgam.c(58145): error C2044: illegal continue
quickjs-amalgam.c(58379): error C2059: syntax error: 'do'
quickjs-amalgam.c(58383): warning C5100: __VA_ARGS__ is reserved for use in variadic macros
quickjs-amalgam.c(58383): note: in expansion of macro '__VA_ARGS__'
quickjs-amalgam.c(58385): error C2059: syntax error: 'while'
quickjs-amalgam.c(58472): error C2065: 'promise_reaction_job': undeclared identifier
quickjs-amalgam.c(58472): warning C4047: 'function': 'JSJobFunc (__cdecl *)' differs in levels of indirection from 'int'
quickjs-amalgam.c(58472): warning C4024: 'JS_EnqueueJob': different types for formal and actual parameter 2
quickjs-amalgam.c(59228): error C2065: 'promise_reaction_job': undeclared identifier
quickjs-amalgam.c(59228): warning C4047: 'function': 'JSJobFunc (__cdecl *)' differs in levels of indirection from 'int'
quickjs-amalgam.c(59228): warning C4024: 'JS_EnqueueJob': different types for formal and actual parameter 2
quickjs-amalgam.c(62080): error C2044: illegal continue
quickjs-amalgam.c(64739): error C2014: preprocessor command must start as first nonwhite space
quickjs-amalgam.c(64739): error C2065: 'ATOMICS_OP_': undeclared identifier
quickjs-amalgam.c(64741): error C2146: syntax error: missing ':' before identifier 'a'
quickjs-amalgam.c(64745): error C2014: preprocessor command must start as first nonwhite space
quickjs-amalgam.c(64745): error C2065: 'ATOMICS_OP_': undeclared identifier
quickjs-amalgam.c(64747): error C2146: syntax error: missing ':' before identifier 'a'
quickjs-amalgam.c(64751): error C2014: preprocessor command must start as first nonwhite space
quickjs-amalgam.c(64751): error C2065: 'ATOMICS_OP_': undeclared identifier
quickjs-amalgam.c(64753): error C2146: syntax error: missing ':' before identifier 'a'
quickjs-amalgam.c(64757): error C2014: preprocessor command must start as first nonwhite space
quickjs-amalgam.c(64757): error C2065: 'ATOMICS_OP_': undeclared identifier
quickjs-amalgam.c(64759): error C2146: syntax error: missing ':' before identifier 'a'
quickjs-amalgam.c(64739): error C2051: case expression not constant
quickjs-amalgam.c(64745): error C2051: case expression not constant
quickjs-amalgam.c(64751): error C2051: case expression not constant
quickjs-amalgam.c(64757): error C2051: case expression not constant
quickjs-amalgam.c(65055): error C2043: illegal break
quickjs-amalgam.c(66458): error C2065: 'c': undeclared identifier
quickjs-amalgam.c(66458): error C2099: initializer is not a constant
quickjs-amalgam.c(66460): error C2059: syntax error: 'else'

@saghul
Copy link
Contributor Author

saghul commented Mar 21, 2025

@bnoordhuis Do you happen to know if The Redmond Compiler chokes on preprocessor marcos names like reserved words in C files, but not in header files?!

@bnoordhuis
Copy link
Contributor

Not to my knowledge but that's not quite the same thing as 'no'. :-)

I built commit fd5f6f3 locally and ran amalgam.js but the line numbers from CI don't match up with the generated quickjs-amalgam.c. Do you see the same thing?

@saghul
Copy link
Contributor Author

saghul commented Mar 23, 2025

I'll give it a nother try after you merge that and I rebase. I'll also try it on MinGW to double check...

@saghul saghul force-pushed the win-test-amalgam branch from fd5f6f3 to f9f72a5 Compare March 23, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saghul @bnoordhuis