-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add symbolic link to examples #83
Conversation
Hm, the maven build didn't like it, let me investigate why |
@abelsromero @LightGuard is this a known issue with the asciidoctor maven plugin? |
I created asciidoctor/asciidoctor-maven-plugin#588 to track this |
This comment was marked as outdated.
This comment was marked as outdated.
I have a setup that works here:
|
c51b3b0
to
e76c205
Compare
Using @gsmet's example above I managed to make it work (but without compiling, since it would require setting the dependencies and put in the expected packages). I think we can add the |
I /think/ I included this new stuff in the template. |
@gsmet that's right, you did, but https://github.com/quarkusio/quarkus/blob/main/independent-projects/tools/base-codestarts/src/main/resources/codestarts/quarkus-extension/code/quarkiverse/java/docs/pom.tpl.qute.xml#L28 assumes that everything under the |
17bfcdb
to
75f1e6b
Compare
Yeah, for me, the whole point of that was to have compilable examples. If not compilable, better add them directly in the doc and not bother about creating external files. |
They are already compiled when the integration tests are executed, so the idea is to just reference them in the docs instead of having it copied somewhere |
I answered asciidoctor/asciidoctor-maven-plugin#588 but reading this I am confused. This repo is crearly and Antora module, it doesn't make sense to use the asciidoctor maven plugin unless you are reusing pieces of docs somehow. Which I would not recommend, Antora adds many things on top and we cannot support them unless we build a full reimplementation. |
@abelsromero so basically, we are using the Maven plugin to get some local rendering to check the output. Except for that, we don't use it. And the modules of several repositories are then aggregated into a single Antora website. So our general aim is to have both outputs working so that people can check the output in their local repo before pushing it. |
Thanks @gsmet I'll integrate that into our story, there may be something we can do to support this preview scenario 🙇 . |
@all-contributors please add @gastaldi for infra |
I've put up a pull request to add @gastaldi! 🎉 |
See https://docs.antora.org/antora/latest/symlinks/ for details