Adds utility to replace Q/DQ ops with torchao quantized linear ops #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1967
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 74f209e with merge base 3bbf42a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
reviewed
Mar 26, 2025
|
|
||
| eager_results = model(activations) | ||
|
|
||
| unwrap_tensor_subclass(model) |
There was a problem hiding this comment.
Let me double check. I thought without it, the exported graph didn't decompose into the Q/DQ ops.
There was a problem hiding this comment.
Removed unwrap_tensor_subclass
jerryzh168
reviewed
Mar 26, 2025
torchao/experimental/quant_api.py
Outdated
| return pattern, replacement | ||
|
|
||
|
|
||
| def replace_q_dq_with_torchao_quantized_linear_ops( |
There was a problem hiding this comment.
can you add a bit context on when this is used in the docstring of the function
There was a problem hiding this comment.
Added context in doc string
metascroy
force-pushed
the
add-q-dq-pass-utils
branch
from
ca5e688 to
74f209e
Compare
jerryzh168
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utility is for export scenarios in which people quantize with Q/DQ layout, and then later want to fuse the ops.