Publically re-export __version__

[CoolCat467]

In this pull request, we publicly re-export __version__. This came up when working on python-trio/trio-websocket#193, where some of the unit test code looks at Trio's version for version-dependent things and mypy is not happy about accessing __version__.

[A5rocks]

IMO we should encourage importlib.metadata (eg in the newsfragment). But this is fine as a bugfix to something we thought worked.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00000%. Comparing base (5ca9662) to head (379d9ce).
Report is 4 commits behind head on main.

Additional details and impacted files

@@               Coverage Diff               @@
##                 main        #3186   +/-   ##
===============================================
  Coverage   100.00000%   100.00000%           
===============================================
  Files             124          124           
  Lines           18460        18460           
  Branches         1216         1216           
===============================================
  Hits            18460        18460           

Files with missing lines	Coverage Δ
src/trio/__init__.py	100.00000% <100.00000%> (ø)

[jakkdl]

IMO we should encourage importlib.metadata (eg in the newsfragment). But this is fine as a bugfix to something we thought worked.

well, it does work currently so this isn't really a bugfix per se. By publicly re-exporting it we're making it part of the official API, so I think perhaps this shouldn't be done at all?

[A5rocks]

IMO we should encourage importlib.metadata (eg in the newsfragment). But this is fine as a bugfix to something we thought worked.

well, it does work currently so this isn't really a bugfix per se. By publicly re-exporting it we're making it part of the official API, so I think perhaps this shouldn't be done at all?

The comment implies we thought it would work, and that it does in pyright. Also, is this PR even necessary?:

(.venv) PS C:\Users\A5rocks\Documents\Temp\a> mypy -c "import trio; reveal_type(trio.__version__)"
<string>:1: note: Revealed type is "builtins.str"
Success: no issues found in 1 source file

[CoolCat467]

Try with --strict or at the very least --no-implicit-reexport