Sync Py_TPFLAGS_MANAGED_DICT for PyPy3.11 across the codebase
#5537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the `Py_TPFLAGS_MANAGED_DICT` logic in `include/pybind11/attr.h` to match the one used in `include/pybind11/detail/class.h`. This is a followup to pybind#5508.
|
Thanks, sorry I missed that in the previous PR. |
|
What do you think about a very slight more ambitious solution? Untested: In pybind11/detail/common.h: #if PY_VERSION_HEX < 0x030B0000 || defined(PYPY_VERSION)
#define PYBIND11_BACKWARD_COMPATIBILITY_TP_DICTOFFSET
#endifThen use that in the two places that need to stay in sync. I'm not sure it's the best name for the define, please use what makes the most sense to you. |
|
I'll try and push it, if it works. |
henryiii
approved these changes
Feb 20, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust the
Py_TPFLAGS_MANAGED_DICTlogic ininclude/pybind11/attr.hto match the one used ininclude/pybind11/detail/class.h.This is a followup to #5508.
CC @mattip