tests: try to skip test in tests

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
pybind · Mar 20, 2024 · 8e4348a · 8e4348a
1 parent 3d81045
commit 8e4348a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -1089,7 +1089,6 @@ jobs:
           -DDOWNLOAD_EIGEN=ON
           -DCMAKE_CXX_COMPILER=clang++
           -DCMAKE_CXX_STANDARD=17
-          -DPYBIND11_PYTEST_ARGS='-k "not test_throw_nested_exception"'
 
       - name: Build
         run: cmake --build . -j 2

diff --git a/tests/test_exceptions.py b/tests/test_exceptions.py
@@ -4,7 +4,7 @@
 
 import env
 import pybind11_cross_module_tests as cm
-import pybind11_tests  # noqa: F401
+import pybind11_tests
 from pybind11_tests import exceptions as m
 
 
@@ -248,6 +248,11 @@ def pycatch(exctype, f, *args):  # noqa: ARG001
     assert str(excinfo.value) == "this is a helper-defined translated exception"
 
 
+# TODO: Investigate this crash
+@pytest.mark.skipif(
+    sys.platform.startswith("win32") and "Clang" in pybind11_tests.compiler_info,
+    reason="Started sefaulting March 2024",
+)
 def test_throw_nested_exception():
     with pytest.raises(RuntimeError) as excinfo:
         m.throw_nested_exception()