Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VVO to TRIAS-Providers.md #73

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

GerdC
Copy link
Contributor

@GerdC GerdC commented Feb 20, 2024

I have tested this API, no key needed.

Copy link
Member

@derhuerst derhuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the respective JSON file describing the API?

You can check bwegt-trias.json or vrn-trias.json as a template.

@GerdC
Copy link
Contributor Author

GerdC commented Feb 20, 2024

I thought about that before this pull request.

I have no idea what the official coverage is, I'm pretty sure it is not possible to ask TRIAS API about the coverage.
Short tests showed it is possible to route to Kiel and to Constance, so it should be DELFI-land.

I have no client that uses / validates / tests these JSON files.
I'm reluctant providing something I can't test.

@derhuerst
Copy link
Member

I have no idea what the official coverage is, I'm pretty sure it is not possible to ask TRIAS API about the coverage. Short tests showed it is possible to route to Kiel and to Constance, so it should be DELFI-land.

There are currently three levels of coverage that you can express. If you're not sure, pick a rather conservative estimation (e.g. anyCoverage only).

I have no client that uses / validates / tests these JSON files. I'm reluctant providing something I can't test.

The CI validates these, so you'll see after pushing.

Locally, you can use any JSON Schema validator by specifying schema.json as the schema file.

@GerdC
Copy link
Contributor Author

GerdC commented Feb 21, 2024

added vvo-trias.json.
It validates. Checked version 1.1, rendered coverage on my app to check.

Only unchecked guess is "LocationInformationRequest" and "supportedLanguages": [ "en", "de" ]. That is copied from bwegt-trias, which is also a version 1.1 form MENTZ.

data/de/vvo-trias.json Outdated Show resolved Hide resolved
data/de/vvo-trias.json Show resolved Hide resolved
data/de/vvo-trias.json Show resolved Hide resolved
Copy link
Contributor Author

@GerdC GerdC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. Asking for https separately.

data/de/vvo-trias.json Show resolved Hide resolved
data/de/vvo-trias.json Show resolved Hide resolved
@GerdC
Copy link
Contributor Author

GerdC commented Feb 21, 2024

I asked VVO to support https

@derhuerst derhuerst merged commit 010fbef into public-transport:v1 Feb 21, 2024
1 of 2 checks passed
@derhuerst
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants