merge main to pathfinder branch #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added `EntitySoundEffectPacket`, `ParticlePacket`, and `SoundEffectPacket`
Since the returned Task of AsyncEvent.Dispatch now always completes after all subscribers finished I inspected the places where await was used on such tasks. Removed the await in the most cases since that how it was before.
…provements - added IVersionAwareSerializable to extend ISerializable with version specific logic like in the packets - moved some core element serialization methods in their classes fixes psu-de#68
…tead of configuration
Fixed encryption and race conditions, added registration classes to unregister packet handlers and WaitForPacketWhere
…fore, not when play state is entered. This caused a race condition where the server may try to process our client information packet before it switched to play game state, which would throw an exception and disconnect us.
- log protocol version - enable debug logs by default for integration tests - added new latest.log target
Various improvements 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.