Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #200 generalize boundaries line features #223

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

nvkelso
Copy link
Collaborator

@nvkelso nvkelso commented Mar 25, 2024

Fixes #200.

OSM boundaries were quite detailed at mid- and high-zooms, and NE boundaries were a bit too detailed at low zooms.

Solution is to variably adjust the pixel tolerance from 0.1 to 0.4 to reduce file size and visual complexity, while preserving some details on fractional zoom in.

After:
Screenshot 2024-03-25 at 1 33 51 PM

Before:
Screenshot 2024-03-25 at 1 29 18 PM

@nvkelso nvkelso requested a review from bdon March 25, 2024 20:39
Copy link

@bdon bdon merged commit f6c2a1f into protomaps:main Mar 25, 2024
4 checks passed
@nvkelso
Copy link
Collaborator Author

nvkelso commented Mar 25, 2024

For good measure, tile size drops 20-40% across the board.

                z0  z1  z2  z3  z4  z5  z6  z7  z8  z9  z10  z11  z12  z13  z14  z15  all
NEW  boundaries 196  247  362  583  894 1.4k 3.3k  2k 4.8k 3.2k 8.2k 3.6k  2k  1k  738  590 8.2k
OLD   boundaries 241  351  566  892 1.3k 1.9k 8.7k 5.1k  12k 7.6k  14k 6.8k 3.3k 1.4k  884  850  14k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More simplification on country borders
2 participants