Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[encode] Fix CTS fail of max B frames exceed expected number #19

Closed
wants to merge 1 commit into from
Closed

[encode] Fix CTS fail of max B frames exceed expected number #19

wants to merge 1 commit into from

Conversation

lsun30
Copy link
Contributor

@lsun30 lsun30 commented May 28, 2024

Some CTS tests of android.videocodec.cts.VideoEncoderMaxBFrameTest# testMaxBFrameSupport failed with "Number of BFrames in a SubGOP exceeds maximum number of BFrames configured".

Cause is for HEVC encode, CO3->GPB is set to "on" by default, which makes GPB frames are used instead of P frames. In CTS test, GPB frames are considered B frames.

Solution is for HEVC encode, set default CO3->GPB to "off" to use P frames ont GPB frames.

Tracked-On:OAM-118626

@sysopenci
Copy link

Improper Commit Message
Proper Tracked on value is not present in
commit message,make sure Tracked-on: jira-ticket is present

Some CTS tests of android.videocodec.cts.VideoEncoderMaxBFrameTest#
testMaxBFrameSupport failed with "Number of BFrames in a SubGOP
exceeds maximum number of BFrames configured".

Cause is for HEVC encode, CO3->GPB is set to "on" by default, which
makes GPB frames are used instead of P frames. In CTS test, GPB
frames are considered B frames.

Solution is for HEVC encode, set default CO3->GPB to "off" to use
P frames not GPB frames.

Tracked-On: OAM-118626
Signed-off-by: Lina Sun <lina.sun@intel.com>
Copy link

@feijiang1 feijiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsun30 lsun30 closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants