Fix calico/node makefile to default variables properly #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feels a little extreme that we would need the ability to set all those but I don't think it harms anything (though I'm not a make expert). |
|
I'm a little concerned that the scope of this PR means that we're now pushing people away from Maybe in the future we'll have better yaml support and it will make sense to revert this. Who knows |
ozdanborne
approved these changes
Aug 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A lot of variables are set using
:=, but I think the intent of most of those is to provide a default setting if the user hasn't overridden the variable themselves. This PR changes all the settings which a user might want to override to?=which should give the desired behaviour.Release Note