Rebase test #34285
Closed
Rebase test #34285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lazarkov
commented
Jul 10, 2024
lazarkov
commented
* There is no need for SupportsAliroProvisioning checks in Aliro command handlers. If we got into that code, that means that we recognized the command ID on the relevant endpoint's Door Lock cluster, and if we passed cert that means that we had the right feature map bit set too. * There is no reason to do conditional MatterReportingAttributeChangeCallback for the AliroGroupResolvingKey attribute. If we don't support the attribute, the call will just be a no-op. * There's no reason to pass attribute paths to methods that do not use them.
…ion soft timer expiry (project-chip#34095) * Adds fix for WiFi task looping * Adds fix for BLE task priority and indication soft timer expiry * Adds fix for return check * Remove unused cred and add length check * aligned include * Replace `lx` with `x` for all sl_status_t logging * Refactor posting of events to the end of the codeblock * Adds `BLE_DRIVER_TASK_PRIORITY` * Adds static_cast for status in ChipLogging * chore: Refactor show_scan_results function to improve readability and maintainability * chore: Update WiFi join function to use strnlen for SSID length calculation * chore: Update WiFi join function to use strnlen for SSID length calculation * chore: Update BSSID array size in WiFi scan result struct * chore: Update SLAAC OK log message to use formatted IPv6 address * Refactor show_scan_results function for improved readability and maintainability * Refactor show_scan_results function to fix null termination bug * Refactor show_scan_results function to fix null termination bug * Adds fix for NCP macros * Revert BLE timer changes * Fix passkey length validation in sl_wifi_if.cpp * Refactor BLEManagerImpl::_OnPlatformEvent for improved code readability and maintainability * Refactor BLEManagerImpl::_OnPlatformEvent for improved code readability and maintainability * Revert "Refactor BLEManagerImpl::_OnPlatformEvent for improved code readability and maintainability" This reverts commit 9f1b180. * Added locks to avoid race conditions * Addressed comments * Refactor sl_wifi_if.cpp for improved code readability and maintainability * Fix passkey length validation in sl_wifi_if.cpp * Fix BSSID length in wfx_rsi_get_ap_info and wfx_rsi_save_ap_info * Refactor log statement after length checks * Adds missing replace --------- Co-authored-by: brosahay <3526930+brosahay@users.noreply.github.com>
examples/all-clusters-app was broken. Now it points to the correct location again
…ntext project-chip#30392 (project-chip#33481) * Plumb Peer DNS-SD advertisement for TCP support into SessionSetup context * Restyled by clang-format * Fix unit tests * Fix build error * address Boris comments * reflect mdns tcp support in session estabishment * Restyled by clang-format * Update src/app/OperationalSessionSetup.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Update src/app/OperationalSessionSetup.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * fixing minor comments * Restyled by clang-format * add an extra check on tcp support * Restyled by clang-format * add a check on tcp server enablement * add peer info in log * Restyled by clang-format * update log message --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
…34261) - Address spec PRs project-chip#9305/project-chip#9401 re: removing gaps in attribute and command numbering. - Introduce maturity level to everything.
… to serve as PW test fixture classes. (project-chip#34036) * Modified MessagingContext and its subclasses as well as AppContext to reflect PW migration. * Modifed all tests that use LoopbackMessagingContext or AppContext. Moved LoopbackMessagingContext data to heap. * Removed unneeded scope from call to parent setup/teardown * Made some helper functions into class methods. * Restyled by prettier-markdown * Reverted TestICDManager back to using LoopbackMessagingContext * fixing merge conflicts * fixing merge conflicts * Fixed duplicate code and missing semicolon * Trying to update TestReadHandler_DataVersionFiltersTruncated * Restyled by whitespace * Restyled by clang-format * fixed problem with the new TestReadHandler_DataVersionFiltersTruncated * fix in tracing * Changes to MessagingContext member variable initialization in response to code review * Used std::unique_ptr for MessagingContext.mpData --------- Co-authored-by: Restyled.io <commits@restyled.io>
…roject-chip#33299) * test * Adds 1/2 second to delay in step 8 * Adds loop in 0.1s cheks for 10s for reading updated attribute * draft commit * progress * ready for review * review comments * review comments * review comments * Updates tests.yaml * Fix lint * Fix restyle * Fix restyle * Fix restyle * Fix restyle * pr review comments * Removes get_attribute_value_wait function * Step 10 wrapped in exception * Removed unused imports * Removes except Exception from step 10 * AttributeChangeCallback refactor * Removes unnecessary variable * Update endpoint assignment in step 5 * Moves steps into step array for TH * Stardardizes reportInterval values for most steps * Fix restyle * Fix restyle * Step 2 update (max_interval_ceiling_sec, min_interval_floor_sec) * Removes print statement * Fix restyle * Updates AttributeChangeCallback * Fix restyle * Removes comment * Removes comment * Removes redundant acl restore lines * Adds idm 4.2 to tests.yaml * Adds idm 4.2 to tests.yaml * Fix restyle * Update tests.yaml * Updates tests.yaml * Adds comments for execution * Updates AttributePath to AttributePath.from_attribute due to class changes * Downgrades logging.info to logging.debug * Removes setting min interval
When a CommandHandler went away, it invalidated its handles, but did not remove them from the list. This would cause it to fail a fatal assert when the non-empty list was destroyed. The fix is to clear the list once we have invalidated all the handles, since we no longer need to track them once they have been invalidated.
There is no need for SupportsAliroProvisioning checks in Aliro command handlers. If we got into that code, that means that we recognized the command ID on the relevant endpoint's Door Lock cluster, and if we passed cert that means that we had the right feature map bit set too.
* Updated device-energy-management-cluster.xml and energy-evse-cluster.xml using Alchemy and spec commit: dbf7c6dd7206fa4a4647f8a6218325fbe6c8ec6c Note more DEM PRs are yet to merge. * Regen_all checked in. * Added missing energy-management-app.matter * Updated with spec PR project-chip#9251 merged to master. * Updated with spec PR project-chip#9266 (change ForecastId -> ForecastID) * regen_all * Removed extra entryType="PowerAdjustStruct" which causes incorrect generation of a top-level list in the PowerAdjustmentCapability attribute. * Removed extra min="-4611686018427387904" max="4611686018427387903" which causes ZAP to complain about more than 2 byte length. * Updated after regen_all * Reverted max="86400" in RANDOMIZATION_DELAY_WINDOW which upsets some builds * Added missing autogen'd code for DEM changes. * Fix up compilation errors caused by change to forecastID and powerAdjustementCapability list moving one level below. * Added Water Heater Management cluster XML * Added Water Heater Management to controller-clusters.zap * Added Water Heater Management to zap_cluster_list.json * Added Water Heater Management cluster to all-clusters-app.zap * Tried to add apiMaturity="provisional" to silence deprecation warnings when running zap_regen_all.py. Also used Alchemy --featureXML. * Added all-clusters-app.matter and controller-clusters.matter after regen_all * Added output from regen_all.py * Updated .zap files after adding provisional flag. * Added Java matter controller now that apiMaturity=provisional has popped out. * Trying to remove Thread Border Router Management in controller-clusters.zap as a test. * Removed water-heater-management-server for now so compilers don't try to compile it. * Reverted all-clusters-app.zap (removed Water heater). Reverted controller-clusters.zap (put back Thread Border Router, removed Water Heater) * updated all-clusters-app.matter after removing WaterHeaterManagement cluster (to avoid compile failures). * Candidate fix for THREAD_BORDER_ROUTER_MANAGEMENT_CLUSTER which resolves the error. [Should be a duplicate of PR project-chip#34000 when that merges. * Addressing review comments from Boris * Regenerate files * Regenerate files correctly * Removal optional conformance fro DayOfWeekForSequence/ChargingTargets fields in ChargingTargetScheduleStruct + regen zap files * Updated energy-evse-cluster using Alchemy to match Spec PR:9317 based on review that DischargingCurrent was inconsistent. * Updated after regen_all --------- Co-authored-by: pcoleman <pcoleman@geotogether.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
…nabled (project-chip#32807) * Modify android chiptool crash * Update src/controller/CHIPDeviceController.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Change FindCommissionedDevice timing * Change CommissioningStageComplete call timing --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
This makes it simpler to figure out who CASE establishments are happening with.
…w use the 3rd arg of TestStep to split the verification step into a separate string. Helps with readability and PEP8 long line warnings. (project-chip#34243)
…p#34257) Contact sensor uses some gn args to enable OTA encryption. This means that an upcoming OTA image must be encrypted with the same key provided by chip_with_ota_key. Signed-off-by: marius-alex-tache <marius.tache@nxp.com>
…hip#34155) This mainly reuses the default defines for test setup parameters. No functional changes.
pullapprove
bot
requested review from
p0fi,
tima-q,
tobiasgraf,
pidarped,
turon,
plauric,
vivien-apple,
rcasallas-silabs,
wiba-nordic,
ReneJosefsen,
woody-apple,
robszewczyk,
younghak-hwang,
saurabhst,
yunhanw-google,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic and
tehampson
|
PR #34285: Size comparison from 171843d to 3ed9651 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.