Make sure device map is accessed safely with lock

project-chip · Feb 19, 2025 · 9d59496 · 9d59496
1 parent 4782a4f
commit 9d59496
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/darwin/Framework/CHIP/MTRDeviceController_XPC.mm b/src/darwin/Framework/CHIP/MTRDeviceController_XPC.mm
@@ -73,13 +73,15 @@ @implementation MTRDeviceController_XPC
 - (void)_updateRegistrationInfo
 {
     dispatch_async(self.workQueue, ^{
+        std::lock_guard lock(*self.deviceMapLock);
+
         NSMutableDictionary * registrationInfo = [NSMutableDictionary dictionary];
 
         NSMutableDictionary * controllerContext = [NSMutableDictionary dictionary];
         NSMutableArray * nodeIDs = [NSMutableArray array];
 
         for (NSNumber * nodeID in [self.nodeIDToDeviceMap keyEnumerator]) {
-            MTRDevice * device = [self _deviceForNodeID:nodeID createIfNeeded:NO];
+            MTRDevice * device = self.nodeIDToDeviceMap[nodeID];
             if ([device delegateExists]) {
                 NSMutableDictionary * nodeDictionary = [NSMutableDictionary dictionary];
                 MTR_REQUIRED_ATTRIBUTE(MTRDeviceControllerRegistrationNodeIDKey, nodeID, nodeDictionary)