refactor: move exports.types to top

[JounQin]

Reference: https://devblogs.microsoft.com/typescript/announcing-typescript-4-7/#package-json-exports-imports-and-self-referencing

[privatenumber]

I've seen that but TS seemed to have no problem reading types for me. Not to mention, object keys inherently have no order.

Is it actually breaking something for you?

[JounQin]

It is required when using moduleResolution: "Node16" or moduleResolution: "NodeNext".

Please read the reference I linked.

The order in exports matters.

See also in Node's official document

[JounQin]

7d501be

I noticed you actually added correct types for imports for eslint-import-resolver-typescript

[privatenumber]

Please read the reference I linked.

I've read it already and I even followed up here.

I noticed you actually added correct types for imports for eslint-import-resolver-typescript

I don't know what you're talking about.

Anyway, is it actually breaking something for you?

(Also, please use the Edit Comment feature instead of commenting multiple times in a row.)

[JounQin]

I've read it already and I even microsoft/TypeScript-Website#2120 (comment).

See: It is required when using moduleResolution: "Node16" or moduleResolution: "NodeNext", it will be broken when enabled.

See also import-js/eslint-import-resolver-typescript#113

I don't know what you're talking about.

I referenced your previous commit 7d501be

[privatenumber]

I'm wondering if you're just saying that because the docs say so, or if you're actually experiencing not getting types in a project.

Please answer if it's actually breaking something for you.

[JounQin]

if you're actually experiencing not getting types in a project.

Yes, I start to use moduleResulution: "Node16" in recent days, incorrect types breaks ts.

[privatenumber]

I'm interested in investigating that.

I tried that out and it works fine:

Can you provide reproduction details?

[privatenumber]

Any updates @JounQin ?

[JounQin]

Any updates @JounQin ?

I didn't spend much time on it, it's just spec.

[privatenumber]

If you don't plan to investigate it, I will merge it as a refactor because fix triggers a release.

I hope you do though because you said the types weren't working for you.

[JounQin]

If you don't plan to investigate it, I will merge it as a refactor because fix triggers a release.

I hope you do though because you said the types weren't working for you.

That's fine, if I meet the error again, I'll post here.

Personally, I think a change align to spec should trigger a release.

Whatever, it doesn't matter.

[privatenumber]

Prefer not to version bump if we don't know what the impact of the change is.

[JounQin]

Prefer not to version bump if we don't know what the impact of the change is.

@privatenumber

I think you're right here now.

Like microsoft/TypeScript#50067 and unplugin/unplugin-auto-import#243, I think we should prefer type: "module".

HDYT?

[privatenumber]

Thanks for the insightful reference. I'll keep this in mind in future projects.

I'm currently don't see a problem in get-tsconfig though. Maybe it's the named export. It's working here with moduleResolution: "node16": https://stackblitz.com/edit/node-5pfnos?file=index.ts

[JounQin]

I'm currently don't see a problem in get-tsconfig though. Maybe it's the named export. It's working here with moduleResolution: "node16"

That's great then! I'm also always preferring named export everywhere.

[privatenumber]

I updated the exports as per the recommendation of the TypeScript Issue you linked:
8516d5a

[privatenumber]

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀