Remove prometheus_process_collector

praekeltfoundation · Jul 30, 2024 · aec3128 · aec3128
1 parent 3357143
commit aec3128
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -54,14 +54,14 @@ jobs:
         run: |
           mix deps.get
 
-      - name: Compile prometheus_process_collector
-        run: |
-          # The prometheus_process_collector's makefile doesn't work properly
-          # for new OTP, so we set the variables it needs in a way that works.
-          export ERTS_INCLUDE_DIR=$(erl -noshell -eval "io:format(\"~s/erts-~s/include/\", [code:root_dir(), erlang:system_info(version)])." -s init stop)
-          export ERL_INTERFACE_INCLUDE_DIR=$(erl -noshell -eval "io:format(\"~s\", [code:lib_dir(erl_interface, include)])." -s init stop)
-          export ERL_INTERFACE_LIB_DIR=$(erl -noshell -eval "io:format(\"~s\", [code:lib_dir(erl_interface, lib)])." -s init stop)
-          MIX_ENV=test mix deps.compile prometheus_process_collector
+      # - name: Compile prometheus_process_collector
+      #   run: |
+      #     # The prometheus_process_collector's makefile doesn't work properly
+      #     # for new OTP, so we set the variables it needs in a way that works.
+      #     export ERTS_INCLUDE_DIR=$(erl -noshell -eval "io:format(\"~s/erts-~s/include/\", [code:root_dir(), erlang:system_info(version)])." -s init stop)
+      #     export ERL_INTERFACE_INCLUDE_DIR=$(erl -noshell -eval "io:format(\"~s\", [code:lib_dir(erl_interface, include)])." -s init stop)
+      #     export ERL_INTERFACE_LIB_DIR=$(erl -noshell -eval "io:format(\"~s\", [code:lib_dir(erl_interface, lib)])." -s init stop)
+      #     MIX_ENV=test mix deps.compile prometheus_process_collector
 
       - name: Run tests
         run: |

diff --git a/mix.exs b/mix.exs
@@ -48,7 +48,8 @@ defmodule TurnJunebugExpressway.Mixfile do
       {:gettext, "~> 0.17.1"},
       {:prometheus_phoenix, "~> 1.3.0"},
       {:prometheus_plugs, "~> 1.1.5"},
-      {:prometheus_process_collector, "~> 1.6.0"},
+      # It looks like we don't actually need this.
+      # {:prometheus_process_collector, "~> 1.6.0"},
       {:plug_cowboy, "~> 2.1"},
       {:jason, "~> 1.1"},
       {:amqp, "~> 1.3"},