Updated opening hour fixture for tests, and added 'document' to non-t…

…ext input detection
praekeltfoundation · Sep 4, 2024 · 08e8979 · 08e8979
1 parent 378b59d
commit 08e8979
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 12 deletions.
diff --git a/HelpCentre/QA/flows/agent-greeting.md b/HelpCentre/QA/flows/agent-greeting.md
@@ -73,7 +73,7 @@ card GetPageContent, then: SendGreeting do
 end
 
 card SendGreeting when is_nil_or_empty(chat.assigned_to) do
-  substituted_msg = substitute(greeting_msg, "{operator_name}", "{a MomConnect operator}")
+  substituted_msg = substitute(greeting_msg, "{operator_name}", "a MomConnect operator")
 
   text("@substituted_msg")
 end

diff --git a/HelpCentre/QA/flows/intro-to-helpcentre.md b/HelpCentre/QA/flows/intro-to-helpcentre.md
@@ -546,7 +546,8 @@ card CheckInbound when num_inbound_attempts > 1 and helpdesk_open == true, then:
 end
 
 card CheckInbound
-     when user_question == "image" or user_question == "audio" or user_question == "video",
+     when user_question == "image" or user_question == "audio" or user_question == "video" or
+            user_question == "document",
      then: NonTextDetected do
   num_inbound_attempts = num_inbound_attempts + 1
   log("Non text input found. Setting num_inbound_attempts = @num_inbound_attempts")

diff --git a/HelpCentre/QA/flows_json/agent-greeting.json b/HelpCentre/QA/flows_json/agent-greeting.json
diff --git a/HelpCentre/QA/flows_json/intro-to-helpcentre.json b/HelpCentre/QA/flows_json/intro-to-helpcentre.json
diff --git a/HelpCentre/QA/tests/agent-greeting_test.exs b/HelpCentre/QA/tests/agent-greeting_test.exs
@@ -39,7 +39,7 @@ defmodule AgentGreetingTest do
   defp set_config(step) do
     step
     |> FlowTester.set_global_dict("settings", %{
-      "working_hours_start_hour" => "6",
+      "working_hours_start_hour" => "5",
       "working_hours_end_hour" => "19",
       "working_hours_start_day" => "2",
       "working_hours_end_day" => "6"
@@ -90,7 +90,7 @@ defmodule AgentGreetingTest do
   test "get greeting for no agent assigned", %{flow: flow} do
     FlowTester.start(flow)
     |> receive_message(%{
-      text: "👨You are now chatting with {a MomConnect operator}" <> _
+      text: "👨You are now chatting with a MomConnect operator" <> _
     })
   end
 end
diff --git a/HelpCentre/QA/tests/agent-wrap-up_test.exs b/HelpCentre/QA/tests/agent-wrap-up_test.exs
@@ -122,7 +122,7 @@ defmodule AgentWrapUpTest do
   defp set_config(step) do
     step
     |> FlowTester.set_global_dict("settings", %{
-      "working_hours_start_hour" => "6",
+      "working_hours_start_hour" => "5",
       "working_hours_end_hour" => "19",
       "working_hours_start_day" => "2",
       "working_hours_end_day" => "6"

diff --git a/HelpCentre/QA/tests/intro-human-agent_test.exs b/HelpCentre/QA/tests/intro-human-agent_test.exs
@@ -70,7 +70,7 @@ defmodule IntroHumanAgentTest do
   defp set_config(step) do
     step
     |> FlowTester.set_global_dict("settings", %{
-      "working_hours_start_hour" => "6",
+      "working_hours_start_hour" => "5",
       "working_hours_end_hour" => "19",
       "working_hours_start_day" => "2",
       "working_hours_end_day" => "6"

diff --git a/HelpCentre/QA/tests/intro-to-helpcentre_test.exs b/HelpCentre/QA/tests/intro-to-helpcentre_test.exs
@@ -292,7 +292,7 @@ defmodule IntroToHelpCentreTest do
   defp set_config_helpdesk_open(step) do
     step
     |> FlowTester.set_global_dict("settings", %{
-      "working_hours_start_hour" => "6",
+      "working_hours_start_hour" => "5",
       "working_hours_end_hour" => "19",
       "working_hours_start_day" => "2",
       "working_hours_end_day" => "6"

diff --git a/HelpCentre/QA/tests/scheduled-callback-confirmation_test.exs b/HelpCentre/QA/tests/scheduled-callback-confirmation_test.exs
@@ -105,7 +105,7 @@ defmodule ScheduledCallbackConfirmationTest do
   defp set_config(step) do
     step
     |> FlowTester.set_global_dict("settings", %{
-      "working_hours_start_hour" => "6",
+      "working_hours_start_hour" => "5",
       "working_hours_end_hour" => "19",
       "working_hours_start_day" => "2",
       "working_hours_end_day" => "6"

diff --git a/HelpCentre/QA/tests/scheduled-callback-followup_test.exs b/HelpCentre/QA/tests/scheduled-callback-followup_test.exs
@@ -45,7 +45,7 @@ defmodule ScheduledCallbackfollowupTest do
   defp set_config(step) do
     step
     |> FlowTester.set_global_dict("settings", %{
-      "working_hours_start_hour" => "6",
+      "working_hours_start_hour" => "5",
       "working_hours_end_hour" => "19",
       "working_hours_start_day" => "2",
       "working_hours_end_day" => "6"

diff --git a/HelpCentre/QA/tests/scheduled-query-rating_test.exs b/HelpCentre/QA/tests/scheduled-query-rating_test.exs
@@ -44,7 +44,7 @@ defmodule ScheduledQueryRatingTest do
   defp set_config(step) do
     step
     |> FlowTester.set_global_dict("settings", %{
-      "working_hours_start_hour" => "6",
+      "working_hours_start_hour" => "5",
       "working_hours_end_hour" => "19",
       "working_hours_start_day" => "2",
       "working_hours_end_day" => "6"