New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect default terminal in cosmic_settings_config (keybind SUPER+T) when changed #975

Merged

mmstick merged 1 commit into pop-os:master from ellieplayswow:feature/update-default-terminal

Feb 14, 2025

Contributor

ellieplayswow commented Feb 14, 2025

changes tl;dr

you can change your default terminal via COSMIC settings, but cosmic_settings_config is by default bound to cosmic-term
when we change the default terminal, persist this setting if possible by grabbing the relevant exec from its FreeDesktop path

demonstration vid:

2025-02-14.10-42-45.online-video-cutter.com.mp4

resolves pop-os/cosmic-epoch#1557

mmstick reviewed

View reviewed changes

cosmic-settings/src/pages/system/default_apps.rs Outdated Show resolved Hide resolved

mmstick reviewed

View reviewed changes

cosmic-settings/src/pages/system/default_apps.rs Outdated Show resolved Hide resolved

mmstick reviewed

View reviewed changes

cosmic-settings/src/pages/system/default_apps.rs Outdated Show resolved Hide resolved

Contributor Author

ellieplayswow commented Feb 14, 2025

@mmstick sorry about that, have resolved those

mmstick reviewed

View reviewed changes

cosmic-settings/src/pages/system/default_apps.rs Outdated Show resolved Hide resolved

mmstick reviewed

View reviewed changes

cosmic-settings/src/pages/system/default_apps.rs Outdated Show resolved Hide resolved

mmstick reviewed

View reviewed changes

cosmic-settings/src/pages/system/default_apps.rs Outdated Show resolved Hide resolved

Contributor Author

ellieplayswow commented Feb 14, 2025

resolved all 3 - good shout re: canonicalisation

ellieplayswow requested a review from mmstick

February 14, 2025 15:36

Contributor Author

ellieplayswow commented Feb 14, 2025

sorting rustfmt

Member

mmstick commented Feb 14, 2025

I need to check if this is writing only local modifications to ~/.config instead of pulling values from the system.

Contributor Author

ellieplayswow commented Feb 14, 2025

@mmstick no problem, let me know if i've missed anything here

mmstick added a commit to pop-os/libcosmic that referenced this pull request


          feat(cosmic_config): add ConfigGet::get_{local,system_default}

ccc1068

Required by pop-os/cosmic-settings#975 to a modify a config
containing a HashMap which is used to partially-override the system default config
in the compositor.


          feat(default_apps): set default terminal in system_actions config

ca2d57e

mmstick force-pushed the feature/update-default-terminal branch from 4012531 to ca2d57e Compare

February 14, 2025 20:51

Member

mmstick commented Feb 14, 2025

Added a get_local method to the cosmic_config::Config so that we can get the local user config and only write what we've overwritten there.

mmstick approved these changes

View reviewed changes

mmstick merged commit 777cbae into pop-os:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet