Skip to content

Commit

Permalink
Linear Code
Browse files Browse the repository at this point in the history
Linear Code
  • Loading branch information
pmarwah committed May 23, 2017
1 parent 7be5f35 commit 7bb0cd8
Show file tree
Hide file tree
Showing 11 changed files with 590 additions and 13 deletions.
13 changes: 12 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
#Directory Structure Improvements

#As per analyzing the existing code, rather than having all the files in one places, the code base can be modular based on common modules and reusable components

#Require JS is used to include JS files as needed.

#Naming convention has been used to clearly depict the componentname with it action like directive or service to have clear visibility from a dev standpoint also it will help in writing test cases more efficiently.
#Naming convention has been used to clearly depict the componentname with it action like directive or service to have clear visibility from a dev standpoint also it will help in writing test cases more efficiently.

#Common CSS and Images are at the top level itself so that we don't have to traverse through many folders and directories


#Code Improvements

#Clean up index file to include the common components like Header, main body content and charts

#config file will drive the application route and will require the files as well
Empty file added common/common.ctrl.js
Empty file.
2 changes: 1 addition & 1 deletion components/typeAhead/typeAhead.directive.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
scope.current = index;
};
},
templateUrl: 'components/templateurl.html'
templateUrl: 'typeAhead.tpl.html'
}
});

Expand Down
Loading

0 comments on commit 7bb0cd8

Please sign in to comment.