Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation restructure #105

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Documentation restructure #105

merged 7 commits into from
Oct 29, 2024

Conversation

0xJepsen
Copy link
Contributor

@0xJepsen 0xJepsen commented Oct 29, 2024

This PR currently does two things

Works on issue #100

@0xJepsen
Copy link
Contributor Author

0xJepsen commented Oct 29, 2024

So everything works now. There is one small qol thing i am not sure is how pressing. The circom wit-calc does provide a warning of 35 unset signals.

template instances: 62
prime: 21888242871839275222246405745257275088548364400416034343698204186575808495617
prime_str: bn128
templates len: 62
functions len: 0
main header: AESGCTRFOLD_61
[warning] signal #206 is not set
[warning] signal #207 is not set
[warning] signal #208 is not set
[warning] signal #209 is not set
[warning] signal #210 is not set
[warning] signal #211 is not set
[warning] signal #212 is not set
[warning] signal #213 is not set
[warning] signal #214 is not set
[warning] signal #215 is not set
[warning] signal #216 is not set
[warning] signal #217 is not set
[warning] signal #218 is not set
[warning] signal #219 is not set
[warning] signal #220 is not set
[warning] signal #221 is not set
[warning] signal #222 is not set
[warning] signal #223 is not set
[warning] signal #224 is not set
[warning] signal #225 is not set
[warning] signal #226 is not set
[warning] signal #227 is not set
[warning] signal #228 is not set
[warning] signal #229 is not set
[warning] signal #230 is not set
[warning] signal #231 is not set
[warning] signal #232 is not set
[warning] signal #233 is not set
[warning] signal #234 is not set
[warning] signal #235 is not set
[warning] signal #236 is not set
[warning] signal #237 is not set
[warning] signal #238 is not set
[warning] signal #239 is not set
[warning] signal #240 is not set
[warning] signal #241 is not set
number of nodes 10478624, signals 128720
Removed 9599912 unused nodes
Propagated 99905 constants
Global value numbering applied
Found 2852 constants
Removed 453868 unused nodes
Converted to Montgomery form
number of nodes after optimize 424844, signals 128720
circuit graph saved to file: aes-fold.bin

it would be nice to figure out which ones these are and address this. I don't know how critical this is though.

@0xJepsen 0xJepsen marked this pull request as ready for review October 29, 2024 03:10
@0xJepsen 0xJepsen requested a review from thor314 October 29, 2024 03:10
@0xJepsen
Copy link
Contributor Author

Latest constrains:

template instances: 60
non-linear constraints: 142032
linear constraints: 198994
public inputs: 0
private inputs: 96 (80 belong to witness)
public outputs: 36
wires: 328989
labels: 818241

Copy link
Contributor

@thor314 thor314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This looks like a pretty straightforward repo cleanup. Nice to see lines of code go down. I haven't combed over this PR line for line, but I did run tests, and it looks like we're passing. Nice work streamlining the repo Waylon, and good comments.

merge when you're rdy.

@0xJepsen 0xJepsen merged commit 65f823f into main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants