Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sankey): enable custom layers in Sankey diagram #2702

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

pcorpet
Copy link
Contributor

@pcorpet pcorpet commented Mar 29, 2025

The code was actually already handling custom layers, this change only surfaces this capacity in the types.

Copy link

vercel bot commented Mar 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nivo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 0:09am

Copy link
Owner

@plouc plouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plouc
Copy link
Owner

plouc commented Apr 1, 2025

@pcorpet, could you please solve the conflict? Otherwise it looks good to me.

The code was actually already handling custom layers, this change only surfaces this capacity in the
types.
@pcorpet pcorpet force-pushed the sankey-custom-layer branch from 8358bd0 to d23df4c Compare April 1, 2025 12:00
@plouc plouc merged commit 3874974 into plouc:master Apr 2, 2025
4 of 5 checks passed
@plouc
Copy link
Owner

plouc commented Apr 2, 2025

@pcorpet, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants