Skip to content

Commit

Permalink
fix sqlite migration down
Browse files Browse the repository at this point in the history
  • Loading branch information
@frasmage
frasmage committed Sep 2, 2024
1 parent a2c3308 commit 4795faf
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 29 deletions.
5 changes: 4 additions & 1 deletion migrations/2020_10_12_000000_add_variants_to_media.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,13 @@ public function down(): void
'media',
'original_media_id',
function (Blueprint $table) {
// SQLite does not support dropping foreign keys or columns with constraints
// skip removing this column, the `whenTableDoesntHaveColumn`
// method should make this safe to play back
if (DB::getDriverName() !== 'sqlite') {
$table->dropForeign('original_media_id');
$table->dropColumn('original_media_id');
}
$table->dropColumn('original_media_id');
}
);
Schema::whenTableHasColumn(
Expand Down
56 changes: 28 additions & 28 deletions tests/Integration/SourceAdapters/SourceAdapterTest.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => null,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'UploadedFileAdapter' => [
'adapterClass' => UploadedFileAdapter::class,
Expand All @@ -88,8 +88,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => self::EXPECTED_MIME,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'LocalPathAdapter' => [
'adapterClass' => LocalPathAdapter::class,
Expand All @@ -99,8 +99,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => null,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'RemoteUrlAdapter' => [
'adapterClass' => RemoteUrlAdapter::class,
Expand All @@ -110,8 +110,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => self::EXPECTED_MIME,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'RawContentAdapter' => [
'adapterClass' => RawContentAdapter::class,
Expand All @@ -121,8 +121,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => null,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'DataUrlAdapter_base64' => [
'adapterClass' => DataUrlAdapter::class,
Expand All @@ -132,8 +132,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => self::EXPECTED_MIME,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'DataUrlAdapter_urlencode' => [
'adapterClass' => DataUrlAdapter::class,
Expand All @@ -143,8 +143,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => self::EXPECTED_MIME,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'StreamResourceAdapter_Local' => [
'adapterClass' => StreamResourceAdapter::class,
Expand All @@ -154,8 +154,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => null,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'StreamAdapter_Local' => [
'adapterClass' => StreamAdapter::class,
Expand All @@ -165,8 +165,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => null,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'StreamResourceAdapter_Remote' => [
'adapterClass' => StreamResourceAdapter::class,
Expand All @@ -176,8 +176,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => self::EXPECTED_MIME,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'StreamAdapter_Remote' => [
'adapterClass' => StreamAdapter::class,
Expand All @@ -187,8 +187,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => self::EXPECTED_MIME,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'StreamResourceAdapter_Memory' => [
'adapterClass' => StreamResourceAdapter::class,
Expand All @@ -198,8 +198,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => null,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'StreamAdapter_Memory' => [
'adapterClass' => StreamAdapter::class,
Expand All @@ -209,8 +209,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => null,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
'StreamAdapter_Data' => [
'adapterClass' => StreamAdapter::class,
Expand All @@ -220,8 +220,8 @@ public static function adapterProvider(): array
'inferredMime' => self::EXPECTED_MIME,
'clientMime' => self::EXPECTED_MIME,
'size' => self::EXPECTED_SIZE,
'hash_md5' => self::EXPECTED_HASH_MD5,
'hash_sha1' => self::EXPECTED_HASH_SHA1,
'md5Hash' => self::EXPECTED_HASH_MD5,
'sha1Hash' => self::EXPECTED_HASH_SHA1,
],
];
return $data;
Expand Down

0 comments on commit 4795faf

Please sign in to comment.