paths: do not allocate byte slices; use unsigned varints

Signed-off-by: Vicent Marti <vmg@strn.cat>
planetscale · Feb 11, 2025 · 2528cf3 · 2528cf3
1 parent f46418c
commit 2528cf3
Show file tree

Hide file tree

Showing 5 changed files with 91 additions and 75 deletions.
diff --git a/go/tools/asthelpergen/paths_gen.go b/go/tools/asthelpergen/paths_gen.go
@@ -256,7 +256,7 @@ func (p *pathGen) generateWalkCases(spi generatorSPI) []jen.Code {
 		}
 
 		cases = append(cases, jen.Case(jen.Id(stepName+"Offset")).Block(
-			jen.Id("idx, bytesRead").Op(":=").Qual("encoding/binary", "Varint").Call(jen.Index().Byte().Parens(jen.Id("path"))),
+			jen.Id("idx, bytesRead").Op(":=").Id("nextPathOffset").Call(jen.Id("path")),
 			jen.Id("path").Op("=").Id("path[bytesRead:]"),
 			jen.Return(jen.Id("GetNodeFromPath").Call(assignNode, jen.Id("path"))),
 		))