Skip to content

Commit

Permalink
fix: turn off noisy lint rules for now
Browse files Browse the repository at this point in the history
  • Loading branch information
yue4u committed Feb 10, 2025
1 parent f81be4a commit b2821b2
Show file tree
Hide file tree
Showing 12 changed files with 5 additions and 19 deletions.
6 changes: 4 additions & 2 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ const tseslintConfig = tseslint.config(
'@typescript-eslint/no-inferrable-types': 'error',
'@typescript-eslint/ban-ts-comment': 'error',
'@typescript-eslint/prefer-namespace-keyword': 'error',
'@typescript-eslint/no-unsafe-assignment': 'error',
'@typescript-eslint/no-non-null-assertion': 'error',
},
}
Expand All @@ -49,13 +48,16 @@ const typescriptConfig = [
import: _import,
},
rules: {
'@typescript-eslint/no-unsafe-argument': 'off',
'@typescript-eslint/no-unsafe-member-access': 'off',
'@typescript-eslint/no-unsafe-assignment': 'off',
'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/no-unused-vars': [
'error',
{ argsIgnorePattern: '^_', ignoreRestSiblings: true },
],
'@typescript-eslint/no-unnecessary-condition': 'error',
'@typescript-eslint/strict-boolean-expressions': 'error',
'@typescript-eslint/strict-boolean-expressions': 'off',
'@typescript-eslint/consistent-type-definitions': 'off',
'@typescript-eslint/no-empty-interface': 'off',
'import/no-extraneous-dependencies': [
Expand Down
2 changes: 1 addition & 1 deletion packages/icons/src/ssr.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ const CAN_USE_DOM = typeof HTMLElement !== 'undefined'

// Workaround: `extends HTMLElement` の形式でないとbabelのトランスパイルがおかしくなる
if (__SERVER__ || !CAN_USE_DOM) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
// eslint-disable-next-line @typescript-eslint/no-explicit-any
globalThis.HTMLElement = class {} as any
}
1 change: 0 additions & 1 deletion packages/tailwind-config/src/_lib/TailwindBuild.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export class TailwindBuild {
}

static async run(config: Config, css: string) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument
const plugin = tailwindcss({
...config,

Expand Down
2 changes: 0 additions & 2 deletions packages/tailwind-config/src/colors/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,12 @@ export default function cssVariableColorPlugin(
const definitions = defineCssVariables(otherThemes)

return plugin(({ addBase }) => {
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
addBase(definitions)

// styledのTokenInjector移植(background処理除く)
if (cssVariablesV1) {
const cssVariablesV1 = defineCssVariablesV1(themeMap)
// @ts-expect-error FIXME
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
addBase(cssVariablesV1)
}
})
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/no-unsafe-argument */
import * as React from 'react'
import { borderRadius } from '.'

Expand Down
2 changes: 0 additions & 2 deletions packages/tailwind-config/src/docs/borderRadius/index.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
import { config } from '../../'
import type { Config } from 'tailwindcss'

// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
export const borderRadius = (config as Config).theme?.borderRadius ?? {}

export { BorderRadius } from './BorderRadius'
1 change: 0 additions & 1 deletion packages/tailwind-config/src/docs/colors/Colors.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/no-unsafe-argument */
import * as React from 'react'
import { EffectType } from '@charcoal-ui/theme'
import { colors } from '.'
Expand Down
3 changes: 0 additions & 3 deletions packages/tailwind-config/src/gradient/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,20 +30,17 @@ export default function cssVariableColorPlugin(
return plugin(({ addBase, addUtilities }) => {
const css = mapKeys(utilities, (name) => `${VAR_PREFIX}${name}`)
if (selectorOrMediaQuery.startsWith('@media')) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
addBase({
[selectorOrMediaQuery]: {
':root': css,
},
})
} else {
// eslint-disable-next-line @typescript-eslint/no-unsafe-call
addBase({
[selectorOrMediaQuery]: css,
})
}

// eslint-disable-next-line @typescript-eslint/no-unsafe-call
addUtilities(classRules, {
// @ts-expect-error FIXME
variants: ['responsive'],
Expand Down
2 changes: 0 additions & 2 deletions packages/tailwind-config/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
import { GRID_COUNT, mergeEffect } from './foundation'

import { Config } from 'tailwindcss'
Expand Down Expand Up @@ -58,7 +57,6 @@ export function createTailwindConfig({
? unstable_createTailwindConfigTokenV2().theme
: {}

// eslint-disable-next-line @typescript-eslint/no-unsafe-return
return {
theme: {
screens: {
Expand Down
2 changes: 0 additions & 2 deletions packages/tailwind-config/src/tokenV2.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable @typescript-eslint/no-unsafe-assignment */
/* eslint-disable @typescript-eslint/no-unsafe-member-access */
import light from '@charcoal-ui/theme/unstable-tokens/css-variables.json'
import { Config } from 'tailwindcss'
import {
Expand Down
1 change: 0 additions & 1 deletion packages/tailwind-config/src/typography/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ const typographyPlugin = plugin(({ addUtilities }) => {
typographyStyle(style),
])

// eslint-disable-next-line @typescript-eslint/no-unsafe-call
addUtilities(
{
...typographyClasses,
Expand Down
1 change: 0 additions & 1 deletion packages/tailwind-config/src/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ export const mapDefaultKey = <O extends object>(o: O) => {
return JSON.parse(JSON.stringify(o), function reviver(k: string, v: string) {
if (k === 'default') {
const DefaultKey = getDefaultKeyName('v3')
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
this[DefaultKey] = v
return undefined
}
Expand Down

0 comments on commit b2821b2

Please sign in to comment.