Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kiln bake more deterministic #476

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

crhntr
Copy link
Contributor

@crhntr crhntr commented Feb 21, 2024

This change set needs to be reconciled with #475. It should be a relatively simple rebase.

Given a commit sha and a clean git state
When `kiln Bake` builds a tile at two different times
Then the tile checksums are equal

This makes it easier to check if a tile has been tampered with and gives us some safety when building CI.

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@crhntr crhntr force-pushed the make-bake-builds-deterministic branch from cb243c5 to 7e1d5d4 Compare February 21, 2024 00:26
@crhntr crhntr changed the title Given the same commit sha and a clean git state,Kiln Bake builds the exact same tile Make Kiln Bake more deterministic Feb 21, 2024
@crhntr crhntr changed the title Make Kiln Bake more deterministic make kiln bake more deterministic Feb 21, 2024
@crhntr crhntr added the tas-slingshots Created by https://github.com/orgs/pivotal-cf/teams/tas-strategic-initiatives-slingshot label Feb 21, 2024
@crhntr crhntr force-pushed the make-bake-builds-deterministic branch 2 times, most recently from 7750982 to 758d6c5 Compare February 23, 2024 21:20
@crhntr crhntr changed the base branch from main to slingshots-bake-changes February 23, 2024 21:46
@crhntr crhntr force-pushed the make-bake-builds-deterministic branch from 758d6c5 to 7bb3183 Compare February 23, 2024 21:49
@crhntr crhntr merged commit 9acb67b into slingshots-bake-changes Feb 23, 2024
1 check passed
@crhntr crhntr deleted the make-bake-builds-deterministic branch February 23, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tas-slingshots Created by https://github.com/orgs/pivotal-cf/teams/tas-strategic-initiatives-slingshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants