Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade to the latest client-go #59757

Merged
merged 11 commits into from
Mar 27, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 25, 2025

What problem does this PR solve?

Issue Number: ref #58780

Problem Summary:

What changed and how does it work?

Upgrade the client-go dependency to fix tikv/client-go#1593

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Trigger circuit breaker
8d6115ea-4a81-4eda-af02-98a544723e4b

After 10s cool-down interval, it recovers
df3a965b-eb0e-4604-8fe9-5ad974530e17

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Sorry, something went wrong.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 25, 2025
@rleungx
Copy link
Member Author

rleungx commented Feb 26, 2025

/retest

1 similar comment
@rleungx
Copy link
Member Author

rleungx commented Feb 26, 2025

/retest

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.1323%. Comparing base (6bdacaf) to head (de4f3f8).
Report is 74 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59757        +/-   ##
================================================
+ Coverage   73.1579%   76.1323%   +2.9743%     
================================================
  Files          1706       1755        +49     
  Lines        471343     492428     +21085     
================================================
+ Hits         344825     374897     +30072     
+ Misses       105315      94999     -10316     
- Partials      21203      22532      +1329     
Flag Coverage Δ
integration 49.8894% <81.2500%> (?)
unit 73.6189% <75.0000%> (+0.9973%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (∅)
parser ∅ <ø> (∅)
br 63.2692% <ø> (+15.1801%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rleungx
Copy link
Member Author

rleungx commented Feb 26, 2025

/retest

1 similar comment
@rleungx
Copy link
Member Author

rleungx commented Feb 26, 2025

/retest

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 27, 2025
@you06
Copy link
Contributor

you06 commented Feb 27, 2025

/retest

2 similar comments
@you06
Copy link
Contributor

you06 commented Feb 27, 2025

/retest

@rleungx
Copy link
Member Author

rleungx commented Mar 3, 2025

/retest

@rleungx rleungx force-pushed the upgrade-client-go branch from 1de7573 to e174613 Compare March 5, 2025 08:22
@rleungx
Copy link
Member Author

rleungx commented Mar 5, 2025

/retest

@rleungx rleungx force-pushed the upgrade-client-go branch from 5799815 to 9fef6df Compare March 5, 2025 09:56
@rleungx
Copy link
Member Author

rleungx commented Mar 5, 2025

/retest

3 similar comments
@rleungx
Copy link
Member Author

rleungx commented Mar 6, 2025

/retest

@rleungx
Copy link
Member Author

rleungx commented Mar 6, 2025

/retest

@rleungx
Copy link
Member Author

rleungx commented Mar 6, 2025

/retest

@rleungx rleungx force-pushed the upgrade-client-go branch from 9fef6df to 4c5f763 Compare March 6, 2025 05:29
@rleungx
Copy link
Member Author

rleungx commented Mar 6, 2025

/retest

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2025
@rleungx rleungx force-pushed the upgrade-client-go branch from fabcad9 to 1ba6d2f Compare March 6, 2025 10:44
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 6, 2025
@rleungx
Copy link
Member Author

rleungx commented Mar 6, 2025

/retest

@hawkingrei
Copy link
Member

/retest

1 similar comment
@zyguan
Copy link
Contributor

zyguan commented Mar 11, 2025

/retest

@rleungx
Copy link
Member Author

rleungx commented Mar 11, 2025

/retest

rleungx and others added 11 commits March 12, 2025 23:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
fix
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx force-pushed the upgrade-client-go branch from b071cb1 to de4f3f8 Compare March 12, 2025 15:32
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2025
@rleungx
Copy link
Member Author

rleungx commented Mar 14, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2025
@you06
Copy link
Contributor

you06 commented Mar 17, 2025

@3pointer, @GMHDBJD PTAL, some code changes to satisfy the latest client-go.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2025
Copy link

ti-chi-bot bot commented Mar 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-11 06:43:31.719292933 +0000 UTC m=+251767.324821878: ☑️ agreed by hawkingrei.
  • 2025-03-20 07:01:35.041387493 +0000 UTC m=+511788.725623589: ☑️ agreed by tangenta.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@BornChanger BornChanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

br part lgtm.

Copy link

ti-chi-bot bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, disksing, GMHDBJD, hawkingrei, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 27, 2025
@ti-chi-bot ti-chi-bot bot merged commit f3d0e43 into pingcap:master Mar 27, 2025
38 checks passed
disksing pushed a commit to oh-my-tidb/tidb that referenced this pull request Mar 27, 2025
@rleungx rleungx deleted the upgrade-client-go branch April 1, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants