Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the top contributors calculation #376

Merged
merged 8 commits into from
Nov 30, 2023

Conversation

pil0u
Copy link
Owner

@pil0u pil0u commented Nov 29, 2023

Summary of changes and context

Closes #242.

The top_contributors value is added to the City model in the database, and seeded. Not calculated anymore for privacy reasons (not sharing publicly number of Alumni per campus per year). You'll have to trust that the values correspond to the formula:

=MAX(CEILING(0,05*[Alumni 2023]+0,03*[Alumni 2022]+0,01*[Alumni 2021 & before]);10)

Adapted the seed accordingly, we should run it again in production.
Adapted the FAQ accordingly.

Sanity checks

  • Ran the seed successfully
  • The campus page and campus scores page are not broken
  • Overall, the values of top contributors slightly decreased for big campuses, except for the Online campus (the most recent with the biggest growth), which is expected.
  • Linters pass
  • Tests pass
  • Related GitHub issues are linked in the description

@pil0u pil0u changed the title Feat/cities/edit top contributors Change the top contributors calculation Nov 29, 2023
@pil0u pil0u marked this pull request as ready for review November 29, 2023 22:40
@pil0u pil0u requested review from wJoenn, Aquaj and ssaunier November 29, 2023 22:40
@pil0u
Copy link
Owner Author

pil0u commented Nov 29, 2023

Je vais ajouter une stat sur la page /participation

Edit: ✅

@pil0u pil0u merged commit 8c32e59 into main Nov 30, 2023
5 checks passed
@pil0u pil0u deleted the feat/cities/edit-top-contributors branch November 30, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifier la formule des top contributors pour les campus
2 participants