Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2023.11.4 #353

Merged
merged 13 commits into from
Nov 23, 2023
Merged

Release 2023.11.4 #353

merged 13 commits into from
Nov 23, 2023

Conversation

pil0u
Copy link
Owner

@pil0u pil0u commented Nov 23, 2023

dependabot bot and others added 13 commits November 17, 2023 20:23
Bumps [rails](https://github.com/rails/rails) from 7.1.1 to 7.1.2.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.1.1...v7.1.2)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(users): validate that referrer exists

* feat(users): validate city can't change

* feat(users): validate batch can't change

* fix(users): rspec

* fix(users): revert refactos

* fix(users) disable Metrics/ClassLength for user model

* fix(users): rename cant to cannot

* fix(users): move referrer param inside params

* feat(users): add explanation for params[:batch_id] = nil if form_params[:batch_number]

* refactor(users): validations params

* Spacing

* Handle referral_code in a proper update_referrer method (we keep referrer_code unpermitted) and drop the flash message for the batch, it's not worth the effort (after a looooong thought and tests). Forbidding City update is important (and easy) because scoring depends on it. Displaying a proper error message when a user tries a wrong referral code is worth it.

* Add back the batch validation

* Rename update to assign referrer

* Wording

* Rename, again

* Trigger batch/city validations on update

* Rollback to the previous behaviour: referrer cannot be nil after it was set

* Test pass, but behaviour is not as expected

* fix(users): add #to_i to referrer_id to trigger change even if user has no referrer yet

* Explicitly use -1 if referrer is not found

---------

Co-authored-by: pil0u <8350914+pil0u@users.noreply.github.com>
* feat(users): add event_awareness attribute to User

* feat(users): add select input in user form

* fix(users): remove :favourite_language from schema

* fix(users): wording and removed conditional options

* refactor(users): change :event_awareness to enum

* refactor(users): set awareness_options as constant

* Wording

* Move down the awareness question

---------

Co-authored-by: pil0u <8350914+pil0u@users.noreply.github.com>
* Change all external link targets from ext to _blank

* Add missing `rel`s
* feat(snippets): unlock solutions for everyone after 24 hours

* refactor(snippets): rename SolvedPuzzleConstraint to AllowedToSeeSolutionsConstraint

* Change to Time.now.utc, just for the sake of consistency

* Consistent syntax with the release_time in days controller

* Empty commit

* Empty commit (#343)

---------

Co-authored-by: pil0u <8350914+pil0u@users.noreply.github.com>
* Push Edition 2020 participants in a text file

* Transform Riddle achievement into a file-based achievement (to be filled later)
* Update link to Slack thread instead of Slack channel in setup

* Add Louis and remove links in footer

* Fix the impersonate forms

* Fix lock time in Ladder of Insanity prompt

* Get back the Slack links

* Switch the FAQ from footer to header with The Wall. Renamed the Slack link 'community'. Write 'settings' in full letters instead of an icon. Added admin link in header for admins.

* Remove text from the participation page

* Indent

* strftime overkill
* feat(users): add favourite_language to User

* feat(users): add select input for favourite language in user form

* feat(users): auto select user favourite language in new snippet form

* feat(users): add dart, elixir, kotlin and swift to list of languages

* fix(users): rubocop

* refactor(users): move LANGUAGES constant back inside Snippet model

* fix(users): rubocop

---------

Co-authored-by: Jérémie <jeremie.bonal@gmail.com>
* feat(pages): add link to patrons page in settings

* feat(pages): User aura formula

* feat(pages): query users with referrals and aura in PagesController#patrons

* feat(pages): patrons views

* fix(pages): add dynamic value for aura formula instead of 4

* fix(pages): remove User::aura

* feat(pages): test PagesController#patrons @users

* kjgqvsefkjyuqzerljkhgfqezrekl;jgbb

* Create the referral_link method

* Add light feedback on copy button click

* Add text to the Patrons page

* Make code clickable as well

* Add Patrons page in the footer

* Add blank target (open in new tab) in all Slack links

* Fix admin links

* No need aliases

---------

Co-authored-by: pil0u <8350914+pil0u@users.noreply.github.com>
* Switch the Slack deep links to classic links, which also trigger the native pop up but also can open in the browser directly

* Add a link to the #general channel on the patrons page

* Filter out users with 0 aura, and in case of equality, most referrals wins (to debate)

* Fix test
@pil0u pil0u merged commit 18f17db into release Nov 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants