Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(users): event awareness #335

Merged
merged 9 commits into from
Nov 19, 2023
Merged

feat(users): event awareness #335

merged 9 commits into from
Nov 19, 2023

Conversation

wJoenn
Copy link
Collaborator

@wJoenn wJoenn commented Nov 19, 2023

Summary of changes and context

closes #334

image

Sanity checks

  • Linters pass
  • Tests pass
  • Related GitHub issues are linked in the description

Copy link
Owner

@pil0u pil0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci 🙏 💯

Quelques petits détails, sinon je pense que c'est un attribut propice à l'usage d'une énumération : une opportunité de découvrir si tu ne connais pas !

app/components/user_form_component.html.erb Outdated Show resolved Hide resolved
app/components/user_form_component.rb Outdated Show resolved Hide resolved
db/schema.rb Outdated Show resolved Hide resolved
app/components/user_form_component.html.erb Outdated Show resolved Hide resolved
db/migrate/20231119105530_add_event_awareness_to_users.rb Outdated Show resolved Hide resolved
app/components/user_form_component.rb Outdated Show resolved Hide resolved
@pil0u
Copy link
Owner

pil0u commented Nov 19, 2023

@wJoenn Pour info chez moi le formulaire ne fait pas persister les données, c'est une question de gestion des params. Je suis en train de fix

@wJoenn
Copy link
Collaborator Author

wJoenn commented Nov 19, 2023

Pour info chez moi le formulaire ne fait pas persister les données

J'ai pas du tout ce probleme

Le.Wagon.x.Advent.of.Code.-.Brave.2023-11-19.22-30-20.mp4
irb(main):002> User.last.event_awareness
  User Load (0.5ms)  SELECT "users".* FROM "users" ORDER BY "users"."id" DESC LIMIT $1  [["LIMIT", 1]]
=> nil
irb(main):003> User.last.event_awareness
  User Load (0.7ms)  SELECT "users".* FROM "users" ORDER BY "users"."id" DESC LIMIT $1  [["LIMIT", 1]]
=> "linkedin"

@pil0u
Copy link
Owner

pil0u commented Nov 19, 2023

C'est peut-être une question de navigateur ? Ou un truc que j'ai dû zapper... je reload la db pour voir

Screen.Recording.2023-11-19.at.22.35.20.mov

@pil0u
Copy link
Owner

pil0u commented Nov 19, 2023

Hmm c'était la db, fausse alerte ! J'ai run les migrations quand j'étais pas à jour sur la branche

@pil0u pil0u merged commit b92ddac into main Nov 19, 2023
5 checks passed
@pil0u pil0u deleted the feat/users/event-awareness branch November 19, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajouter un dropdown dans les paramètres utilisateurs : comment ont-ils connu la plateforme
3 participants