Add option to mark selected page in header.inc

[Aaron-Junker]

This mimics the behaviour of www.php.net.

It currently adds this behaviour to the qa page.

[Aaron-Junker]

@cmb69 what do I have to do that someone will review this.

[cmb69]

Hmm, it looks like all these variables don't really work; e.g. $TITLE is almost always Quality Assurance for web-qa for me, except for those pages where it is explicitly passed to common_header(). Apparently, that has been broken with some "refactoring". I suggest to focus on that first, before introducing more of these variables.

[Aaron-Junker]

.

@cmb69 This is now fixed.

[Aaron-Junker]

@cmb69

[cmb69]

Your patch does not make any difference, from what I can tell, because $CURRENT_PAGE is not set for qa.php.net.

[Aaron-Junker]

@cmb69 I'm very sorry. I thought I mentioned it in the description. I added these in php/web-qa#36

Sorry for tjis inconvenience

[cmb69]

Ah, now I see. Thanks! I think this is okay (I left a comment on the web-qa PR, though), but I really think that we should clean up that terrible code before proceeding with more features.

[Aaron-Junker]

Ah, now I see. Thanks! I think this is okay (I left a comment on the web-qa PR, though)

@cmb69 This is now fixed.

but I really think that we should clean up that terrible code before proceeding with more features.

This may be something I will look into in the future (maybe backport changes from web-php to here. See also php/web-php#523). But in my opionion this should not block merging this PR.

[cmb69]

Thank you! Looks good to me now.

But in my opionion this should not block merging this PR.

Right. It's just that I want to avoid further improvements, before we have the code cleaned up; at least a bit.