Removed ext/oci8 and ext/pdo_oci #13327
Conversation
github-actions
bot
added
Category: Build System
Extension: oci8
Extension: pdo_oci
labels
| @@ -73,8 +73,6 @@ runs: | |||
| ${{ inputs.skipSlow == 'false' && '--with-snmp' || '' }} \ | |||
| ${{ inputs.skipSlow == 'false' && '--with-unixODBC' || '' }} \ | |||
| ${{ inputs.skipSlow == 'false' && '--with-pdo-odbc=unixODBC,/usr' || '' }} \ | |||
| $([ -d "/opt/oracle/instantclient" ] && echo '--with-pdo-oci=shared,instantclient,/opt/oracle/instantclient') \ | |||
There was a problem hiding this comment.
The CI should be moved to the PECL repos.
There was a problem hiding this comment.
I'll add you as a collaborator so you can do so.
There was a problem hiding this comment.
Thank you, I contribute to CI a lot, but I am not a C expert so I would be happy if someone else can do this.
The first step should be to convert GH workflows into resuable GH actions so the PECL repos can take the advantage of sanitizers, nightly jobs, ...
Also CI parts like https://github.com/php/php-src/blob/php-8.3.2/.github/workflows/nightly.yml#L81 should be moved.
To the migration, I wonder if monorepo for all pecl packages under php org was considered. IMO, managing oci8 and pdo_oci separately imply a lot of extra time and communication needed to maintain. Not mentioning keeping the changes consistent is quite resource demanding.
|
Maybe these can be removed. https://github.com/php/php-src/blob/master/.github/actions/setup-oracle/action.yml |
|
A few other places that we have leftover OCI references:
|
|
Thanks @Ayesh — I left the |
They now live in their own repositories: https://github.com/php/pecl-database-oci8 https://github.com/php/pecl-database-pdo_oci
|
TIL that we have such a thing! Committed, and will merge. |
In addition to the version bump, this commit drops support for the oci8 extension within PHP itself. This extension no longer builds with the latest dev-db/oracle-instantclient (bug 928312, the ./configure check is looking for 32-bit libs), and upstream PHP has moved the extension to a separate PECL repository: * php/php-src#13327 * https://wiki.php.net/rfc/unbundle_imap_pspell_oci8 Anyone interested in Oracle support should work on packaging those two PECL extensions. Closes: https://bugs.gentoo.org/928312 Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
|
Just to note that this was never documented in UPGRADING. |
Fixes [13327-comment](php#13327 (comment)) Signed-off-by: Ayesh Karunaratne <ayesh@aye.sh>
Fixes [13327-comment](php#13327 (comment)) Signed-off-by: Ayesh Karunaratne <ayesh@aye.sh>
…le (#14619) Fixes [13327-comment](#13327 (comment)) Signed-off-by: Ayesh Karunaratne <ayesh@aye.sh>
They now live in their own repositories:
https://github.com/php/pecl-database-oci8
https://github.com/php/pecl-database-pdo_oci