expose metrics per process in fpm status #12759
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdaguerre
force-pushed
the
openmetrics-status-alternative
branch
4 times, most recently
from
fbd131d to
f8a8785
Compare
|
Hi @bukka any help on fixing the broken test would be highly appreciated because I don't undersatnd how my changes could affect the JSON format... |
|
@cdaguerre It is probably failing some ASAN check. I just pushed some tester changes to be able see child logs if there is an error which might show more so please try to rebase and push force it here. If it doesn't show anything useful, then the next step would be to build with ASAN locally but lets first see if there are any useful child logs. |
cdaguerre
force-pushed
the
openmetrics-status-alternative
branch
2 times, most recently
from
d3e4771 to
2db1ea7
Compare
cdaguerre
force-pushed
the
openmetrics-status-alternative
branch
from
2db1ea7 to
12a7c77
Compare
pderrierw
reviewed
Mar 5, 2024
| "# HELP phpfpm_accepted_connections The number of requests accepted by the pool\.\n" . | ||
| "# TYPE phpfpm_accepted_connections counter\n" . | ||
| "phpfpm_accepted_connections " . $fields['accepted conn'] . "\n" . | ||
| "phpfpm_up{pool=\"" . $fields['pool'] . "\"} 1\n" . |
There was a problem hiding this comment.
I think test is failing due to the escaping here. Maybe it should be double escaped ? (not sure)
Suggested change
| "phpfpm_up{pool=\"" . $fields['pool'] . "\"} 1\n" . | |
| "phpfpm_up{pool=\\\"" . $fields['pool'] . "\\\"} 1\n" . |
|
@bukka @cdaguerre any update on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9494
Supersedes #9646