Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistranslations in PCRE #227

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Fix mistranslations in PCRE #227

merged 2 commits into from
Dec 25, 2024

Conversation

nyan-dot
Copy link
Contributor

#225 と同様の変更をpreg_match_all()とpreg_split()と定義済み定数のページにも反映し(「一致」としていたのは「マッチ」に修正)、
PREG_UNMATCHED_AS_NULL辺りの訳を調整し(reportは「通知」より「報告」だと思うが、それも違和感があるので訳を崩した)、
加えて2箇所を微調整(「無意味」だとエラーが起きるというより単に何も起きない感じがあり、「ある部分」だとthe partsではなくa partの語感がある)。

元ページ:
https://www.php.net/manual/en/function.preg-match.php
https://www.php.net/manual/en/function.preg-match-all.php
https://www.php.net/manual/en/function.preg-split.php
https://www.php.net/manual/en/pcre.constants.php

Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!
適用先が複数あったのですね、大変助かりました!

@KentarouTakeda KentarouTakeda merged commit d86ade6 into php:master Dec 25, 2024
1 check passed
@nyan-dot nyan-dot deleted the fix branch December 25, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants