-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions/Membership: add MongoDB #3611
Conversation
Updates: * https://www.php.net/manual/en/extensions.alphabetical.php * https://www.php.net/manual/en/extensions.membership.php The MongoDB extension appears to be missing from the extension pages. The build for this will fail due to the extension not having a `book.xml` page, but a `set.xml` page instead and the QA script not handling this. Should I rename the XML file ? Or submit an update for the QA script ? Ref: * https://www.php.net/manual/en/set.mongodb.php
I honestly don't know the difference between a book and a set, but if it's a simple case of renaming the XML file I think it's better to rename the file than to adapt the QA script. |
A book is a "complete book" and a set is a collection of books and is the top of the DocBook structural hierarchy (according to the official docs for book and set).
To add MongoDB to the list of extensions, changing I just checked and other than MongoDB, only MySQL is using a
My preference would be to update these two extensions' sets to books. If nobody has any objections, I can take a look at this this weekend. What do you think @Girgias? |
It was done because it was documenting two extensions, bson, and mongodb. This shouldn't be needed now, as these have been merged into one extension ages ago.
|
I think you should just leave fixing this to the mongodb folk, they keep these docs up to date.
|
Hey @php-pulls, you're still showing up as that, and not as @derickr. :) |
I think I fixed that now with this email?
|
I am in favour of moving away from |
That will take a while, as we currently have no bandwidth for larger changes to docs. If somebody else can and wants to handle this, it would be greatly appreciated! |
I've opened a PR in Please note that the changes made in the If needed, I can help with opening a PR in some of the translations. Since all of these changes are to the markup and to the |
@jrfnl The |
Closing as fixed via the transformation of the MongoDB docs from a |
Updates:
The MongoDB extension appears to be missing from the extension pages.
The build for this will fail due to the extension not having a
book.xml
page, but aset.xml
page instead and the QA script not handling this. Should I rename the XML file ? Or submit an update for the QA script ?Ref: