Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build (forward slashes everywhere) #214

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

alfsb
Copy link
Member

@alfsb alfsb commented Jan 22, 2025

There is nobody building on Windows? Or, there is way to CI test on Windows boxes? I can only borrow a Windows box very rarely to test these things.

On a Win10 machine, this PR fixes:

C:\phpdoc>php doc-base\configure.php -q --disable-sources-file --with-lang=de
configure.php on PHP 8.3.14

doc-base: e62034723f03e24728247468043a2c5ffc358a34
en:       f944fb771cf18594fd89f3568f216b4f1a2b7002
de:       d3c11067a19da9059d28b58c8d6f3a9c64a02cf0

Iterating over extension specific version files... OK
Saving it... OK
Modification history file C:\phpdoc/en/fileModHistory.php not found.
Creating empty modification history file...done.
Creating file-entities.ent... done
Loading and parsing manual.xml... failed.

[error file:/C:/phpdoc/doc-base/temp/manual.conf 2:74] Invalid URI: C:\phpdoc\de\language-defs.ent
[error file:/C:/phpdoc/doc-base/temp/manual.conf 3:78] Invalid URI: C:\phpdoc\de\language-snippets.ent
[error file:/C:/phpdoc/doc-base/temp/manual.conf 4:71] Invalid URI: C:\phpdoc\de\extensions.ent
[error file:/C:/phpdoc/doc-base/manual.xml 9:19] PEReference: %translation-defs; not found
[error file:/C:/phpdoc/doc-base/manual.xml 10:23] PEReference: %translation-snippets; not found
[error file:/C:/phpdoc/doc-base/manual.xml 11:25] PEReference: %translation-extensions; not found
[FATAL C:/phpdoc/de/chapters/intro.xml 84:64] Entity 'zb' not defined
[FATAL C:/phpdoc/de/chapters/intro.xml 124:25] Entity 'zb' not defined
[FATAL C:/phpdoc/de/chapters/intro.xml 137:61] Entity 'zb' not defined
[FATAL C:/phpdoc/de/chapters/intro.xml 147:33] Entity 'zb' not defined
[FATAL C:/phpdoc/de/chapters/intro.xml 153:64] Entity 'zb' not defined
[FATAL C:/phpdoc/de/chapters/intro.xml 183:57] Entity 'zb' not defined
[FATAL C:/phpdoc/de/chapters/intro.xml 217:1] chunk is not well balanced
[FATAL file:/C:/phpdoc/doc-base/manual.xml 41:19] Entity 'chapters.intro' failed to parse

Eyh man. No worries. Happ shittens. Try again after fixing the errors above.

@alfsb alfsb merged commit b12b9bb into php:master Jan 27, 2025
11 of 12 checks passed
@alfsb
Copy link
Member Author

alfsb commented Jan 27, 2025

Merged. Now to re-test the other PR in all languages, as this PR showed some languages may fail almost randomly by different file path usage, and internal tools differences between Windows and Linux, if/when I can access a Windows box again.

@alfsb alfsb deleted the rv4 branch January 28, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant