-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idempotent build: manual.xml.in #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to use process instruction for the inclusion of the translation layer and CHM?
The PI alternative for this would be at XML parse, or as after parse fixup? |
I do not think that processing instructions will work, for the same reason that XInclude wont work in general: entities. Files at This PR only focuses on making manual building as idempotent as possible, and for this, it's only necessary to avoid writing/changing files outside |
I plan to merge this and #207 mid January, so it will possible to start working in pushing PnD stuff at the end of |
694e927
to
8f5b45b
Compare
Sorry for the delayed response. Well if PIs are not going to work then this is fine. |
I do not think PIs after parse time are gone to work, because files with undefined entity references are impossible to load (so there is nothing valid to patch or append). There is a way use PIs at parse time, returning raw CDATA while loading a XML file? @nielsdos |
I don't think so. |
Merging. There is still a few points where |
I cannot find one, either. We are so accustomed to using |
This PR removes the last non-PhD related, non idempotency of manual. All other are PhD related and will need coordination.
Tested on all languages, with and without CHM enabled. Few languages have broken XML files inside
chmonly/
. This PR need to be tested on Windows, in particular, by builders of CHM manuals, to see if nothing got broken in this process. The tests showed identical XML output, but changes on DTD area.Opened to review, but I'm not expecting merging this before 2025. There is nothing blocking this, really, only to avoid injecting possible breakages near new year festivities.
The broken
chmonly/
files I found are: