Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate documentation about documentation into docs directory #159

Merged
merged 36 commits into from
Oct 22, 2024

Conversation

jimwins
Copy link
Member

@jimwins jimwins commented Oct 4, 2024

This pulls info that was on doc.php.net and in other places within this repo into one docs directory so everything is in one place.

The plan is to have it be published on http://doc.php.net somewhere, too (and redirect old /tutorial links as necessary), but it's browsable through GitHub, like https://github.com/jimwins/doc-base/blob/clean-up-phpdoc-docs/docs/toc.md

docs/README.md Outdated
Comment on lines 52 to 54
"Edit this page" or "Report a problem" links in the header of each page
at [the online version of this documentation](https://doc.php.net/tutorial/),
or through [the GitHub repository](https://www.github.com/php/doc-base/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is no longer in the header but before the user notes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually about the 'Edit this page' link on doc.php.net for editing this meta-documentation, not for the regular manual itself.

(There's no 'Report a problem' link on doc.php.net yet, but I plan to add it.)

docs/editing.md Outdated Show resolved Hide resolved
docs/editing.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/style.md Show resolved Hide resolved
docs/translating.md Outdated Show resolved Hide resolved
docs/translating.md Outdated Show resolved Hide resolved
docs/translating.md Outdated Show resolved Hide resolved
docs/translating.md Outdated Show resolved Hide resolved
@jimwins
Copy link
Member Author

jimwins commented Oct 5, 2024

I ripped out all of the out-of-date info on how the manual is built and just direct questions to systems@php.net for now. We can add back info about where the scripts that do the build live, but it looks like not quite all of them are in the systems repo yet.

@haszi
Copy link
Contributor

haszi commented Oct 6, 2024

As someone who started to contribute to the documentation less than a year ago, I can say that this kind of consolidation and clarification on how to contribute is badly needed. Thanks for this!

README.md Outdated Show resolved Hide resolved
docs/contributing.md Outdated Show resolved Hide resolved
docs/editing.md Outdated Show resolved Hide resolved
Comment on lines +71 to +72
## How do I find missing documentation?
Missing functions (no associated XML files) can be found like so (assuming a doc checkout, and PhD is installed):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be the perfect place to add something about how to generate a list of missing constants, functions, methods, etc. with gen_stub.php. Unfortunately I still don't exactly know how to do that but @kocsismate certainly does.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a great addition, but also not something I know how to do, so I can't add it. I'll open a new issue for it if nobody has suggested text by the time this PR lands.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/joining.md Show resolved Hide resolved
docs/local-setup.md Show resolved Hide resolved
docs/structure.md Outdated Show resolved Hide resolved
descriptions, normal punctuation should be used. Lists, titles, and sentence fragments should not be punctuated with
a period. Sentences need not have two spaces between them. Commas and apostrophes should be used appropriately.

## Personalization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be useful to separate this page into a general and an English style guide as everything above this line applies to all languages/translations while more or less everything below it applies to doc-en only.

docs/structure.md Show resolved Hide resolved
docs/whitespace.md Outdated Show resolved Hide resolved
docs/translating.md Outdated Show resolved Hide resolved
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet some more comments from what I can see in the diff of the previous review and now :)

docs/README.md Outdated Show resolved Hide resolved
docs/cs-for-examples.md Outdated Show resolved Hide resolved
docs/cs-for-examples.md Outdated Show resolved Hide resolved
docs/cs-for-examples.md Outdated Show resolved Hide resolved
docs/cs-for-examples.md Outdated Show resolved Hide resolved
docs/cs-for-examples.md Show resolved Hide resolved
docs/cs-for-examples.md Outdated Show resolved Hide resolved
docs/cs-for-examples.md Outdated Show resolved Hide resolved
docs/local-web-setup.md Outdated Show resolved Hide resolved
docs/cs-for-examples.md Outdated Show resolved Hide resolved
docs/cs-for-examples.md Outdated Show resolved Hide resolved
docs/cs-for-examples.md Outdated Show resolved Hide resolved
@jimwins jimwins marked this pull request as ready for review October 22, 2024 00:52
@jimwins jimwins merged commit d085a57 into php:master Oct 22, 2024
8 of 12 checks passed
@jimwins
Copy link
Member Author

jimwins commented Oct 22, 2024

Getting this up on new doc.php.net server, we can continue to refine content through other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants