-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JSON Transport #7435
base: dev
Are you sure you want to change the base?
Remove JSON Transport #7435
Conversation
5f44276
to
f2db7c9
Compare
f5763bd
to
2ac820e
Compare
Schema is unchanged, no database migration needed.Carry on! '' |
…ndelbox_assign request that does both
* Remove JSON transport from host service * Add mandelbox info request * Remove JSON transport from scaling service * Update run.py, updatee mandelboxDieHandler * Remove transportMap and transportMapLock * Use path instead of query params * Add case for localdev * Add error handling to run script, use strings Cut instead of Trim * Rewrite httpserver tests * Remove JSON transport from tests * Remove config.json from tests * Remove unused import * Formatting * Add kiosk mode, local client and load extension arguments * Handle empty query params * Linting * Fix deploy script, add optional config db setup * Formatting, move config specific steps after compose * Remove unused import * Remove session id from main service * Remove session id from audio service * Always wait for mandelbox to be ready * Finish getMandelboxInfo function in scaling service server * Set mandelbox status to running * Change localdev arg defaults * Change session id field to server-side session id * Add missing field * Remove session id field from assign request * Properly write session id to db
195e89f
to
0dd41af
Compare
Codecov Report
@@ Coverage Diff @@
## dev #7435 +/- ##
==========================================
+ Coverage 56.13% 57.43% +1.29%
==========================================
Files 158 106 -52
Lines 32519 26947 -5572
==========================================
- Hits 18255 15476 -2779
+ Misses 14010 11471 -2539
+ Partials 254 0 -254
Continue to review full report at Codecov.
|
NOTE: this PR must be merged in conjunction with https://github.com/whisthq/brave-core/pull/637 and @MauAraujo's upcoming JSON transport removal PR
Ticket(s) Closed
Description
This PR removes the references to and dependencies on JSON transport from the client extension and the mandelbox scripts. Additionally, it assumes a modified version of the
mandelbox_assign
endpoint that returns the mandelbox ports and secret as well. Finally, certain dev options(kiosk mode, load extension, local client) that are currently being set via JSON transport on dev have been converted to flags onrun.sh
for the mandelbox. NOTE: I have included a rough update to the json_transport endpoint in the host service to support this, but the appropriate change will need to be made in the updated version of the host service the corresponds to this PR.The following features that are currently (in dev) set via JSON transport have been updated to be shared after client connection in this PR:
The following features that are currently (in dev) set via JSON transport have been removed because I couldn't figure out how to hot-switch them on the server or just didn't want them anymore:
Implementation
JSON Transport Conversion
These are handled via updates to the client extension, server extension, and server teleport extension.
JSON Transport Removal from Client
All references to the
json_transport
endpoint have been removed and merged with themandelbox_assign
endpoint.JSON Transport Removal from Mandelboxes
All references to the
config.json
written by the host service have been removed and all environment variables that are now being set by the extension have been removed. Dev options have been kept temporarily to allow setting via options in when usingrun.sh
but are handled in the host service in the same way that the AES key and Sentry environments since they are set on container start instead of after container start.Documentation & Tests Added
N/A
Testing Instructions
This can't be properly tested until the corresponding host service/scaling service update PR is made by @MauAraujo. Stay tuned for updates.
PR Checklist