Refactor/modularize parameter datasets #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gotfrid
approved these changes
Jan 31, 2025
Gero1999
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Hey thanks for this @m-kolomanski. The modularization was perfect, I just noticed some little problems with the download of the datasets, but I think this was my fault when I implemented #141!
They are small changes but I will leave it to your consideration. We can solve them now in this pr or open a new issue.
| options = list( | ||
| scrollX = TRUE, | ||
| scrollY = TRUE, | ||
| lengthMenu = list(c(10, 25, -1), c("10", "25", "All")), |
There was a problem hiding this comment.
suggestion: allow user to copy/download all rows with a whole display of the dataset
(note: menu won't work & is not needed anyways)
Suggested change
| lengthMenu = list(c(10, 25, -1), c("10", "25", "All")), | |
| pageLength = -1, |
| extensions = c("FixedHeader", "Buttons"), | ||
| options = list( | ||
| scrollX = TRUE, | ||
| scrollY = TRUE, |
There was a problem hiding this comment.
suggestion: allow user to copy/download all rows with a whole display of the dataset
Suggested change
| scrollY = TRUE, | |
| scrollY = TRUE, | |
| pageLength = -1, |
|
|
||
| output$adpp_dataset <- DT::renderDataTable({ | ||
| DT::datatable( | ||
| data = CDISC()$adpp, |
There was a problem hiding this comment.
suggestion: do not display row names
Suggested change
| data = CDISC()$adpp, | |
| data = CDISC()$adpp, | |
| rownames = FALSE, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Addresses #144, #63
Description
bslibHow to test
Run the application, check if everything runs smoothly.
Contributor checklist