Skip to content

Added simple recipe for 'onqtam/doctest'. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added simple recipe for 'onqtam/doctest'. #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions recipes/onqtam/doctest/package.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
onqtam/doctest@master
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to use a version tag instead of always pulling from master?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, yes the repo does seem to have tags for each of its releases, so I guess those could be used instead.

Is it generally preferred for recipes not to pull from master?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it generally preferred for recipes not to pull from master?

Yes, as it helps keep the recipes reproducible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahha, I see. Yes that makes sense.

Does that also imply then, that if two different users both wanted reproducible setups, but using two different versions of a library, then we might want two different recipes for that same library (eg. with the version number in the recipe name perhaps) in cget?

Apologies for all the questions, but I'm genuinely interested in finding out what the ideal cget workflow is.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cget doesn't really support installing two different versions in the same cget directory(as two packages are not allowed to install the same file).

You can also add multiple versions of recipe under the same directory, such as onqtam/doctest/1.0/package.txt and onqtam/doctest/2.0/package.txt and then you can refer to it as onqtam/doctest@1.0 or onqtam/doctest@2.0. Both packages are given the same name as onqtam/doctest. Currently, there is no SAT solving, just first-come-first-serve(ie cget just checks if the package is already installed, and then installs). So to fix a correct version, the user should install it first or use a set of recipes that are know to work together.

Of course, this recipe is only useful for picking a usable version. So I dont see the need to add multiple recipes as the user can already do onqtam/doctest@1.0 to pick a certain tag and install.