-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce perses object in package.json and change the way the archives are created #7
Conversation
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@@ -22,28 +22,30 @@ import ( | |||
"github.com/sirupsen/logrus" | |||
) | |||
|
|||
var pluginFiles = []string{ | |||
"dist/", | |||
"TYPE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be better to create a plugin.json file so we can include other metadata, such as author, version, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it makes sense since these metadata info can be found in the package.json
already.
Perhaps we can include the package.json
in the archive as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a specific json file for the plugin could be interesting if we have info that cannot be found in the package.json
or in the file mf-manifest.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we could use the package.json with a custom field perses
if we need to include more metadata as the package.json should hold already the version of the plugin and author. We can add there the plugin type like:
perses:{
pluginType:"panel"
}
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah I like this idea. Will make the changes ! Thanks 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
033cb55
to
688ad21
Compare
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
This PR introduced a new file
TYPE
where you can write the type of the plugin (panel, query, datasource, variable)It also changed a bit how the archive are built.
The archive contained now the file
TYPE
, theREADME.md
and of course the content of thedist
folderAnd it also remove any additional folder that was at the root of the archive and that wasn't necessary.
The archive name contains also the version of the plugin.
Should be merged after #6