add remaining plugins, refactor exports and add test and lint commands #25
Conversation
jgbernalp
force-pushed
the
jgbernalp/add-remaining-plugins
branch
7 times, most recently
from
28a95f7 to
45dc2cb
Compare
Signed-off-by: Gabriel Bernal <gabrielbernalp@gmail.com>
jgbernalp
force-pushed
the
jgbernalp/add-remaining-plugins
branch
from
45dc2cb to
ded75c6
Compare
| return execErr | ||
| } | ||
|
|
||
| if createGroupArchive { | ||
| if execErr := exec.Command("cp", path.Join(pluginName, archiveName), path.Join("./plugins-archive", archiveName)).Run(); execErr != nil { |
There was a problem hiding this comment.
Maybe I forgot something, but here I don't get where the binary plugins-archive is coming from. I can admit I don't even get why we would need that
There was a problem hiding this comment.
It was just for convenience while developing locally to replace it in the Perses side. But we can remove it once we can load a development version of the plugin files from the /plugins/ endpoint in Perses.
There was a problem hiding this comment.
ah yeah makes sense. We will need to provide something quickly, it will be super annoying otherwise to develop a plugin
|
increadible work @jgbernalp !!! 🤯 I just have a small comment and I was wondering when you are saying:
Does that mean we need to merge perses/perses#2557 before this one ? Which is odd for me as the CI is green here and red in the other one. |
I think we can move forward and merge this PR and make this meeting afterward. |
Yes. Is green here because the test of the plugins in isolation are ok. But we don't have integration tests yet. |
|
moving forward on this PR, trusting you about the changes for the various plugin ;) |
this huge PR 😅. Adds the following:
Migrates the remaining plugins:
Changes the way the plugin is exported to match better the editing panels and options
bumps the version to 0.4.0 as the export changes are breaking changes
Adds test and lint commands
Fixes the issue of the panel and datasources editors
Review will be probably better on a small meeting.
This needs perses/perses#2557