Skip to content

Commit

Permalink
revert(scripts/install.ba.sh): No use of setup
Browse files Browse the repository at this point in the history
  • Loading branch information
percebus committed Jan 18, 2025
1 parent 80d47b7 commit 0e9ba2d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/always.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
verify_matrix:
name: Verify
needs: verify
# if: github.ref == 'refs/heads/main' # FIXME
if: github.ref == 'refs/heads/main'
continue-on-error: true
strategy:
max-parallel: 10
Expand Down
2 changes: 1 addition & 1 deletion TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- [ ] `mypy --strict` for all `.py` files
- [ ] Centralize print("✅") in `lib`
- [ ] Remove `src.` from all `import`s
- [ ] Combine `scripts/setup.ba.sh` with `install.ba.sh`

### CLI cmds

Expand All @@ -24,7 +25,6 @@ Move CLI cmds like `pypyr` to `requirements.pipx.txt`
- [x] ~~Rename `requirements.min.txt` to `requirements.main.txt`, to hint that it comes from `poetry` `main` dependencies.~~
- [x] ~~Fix `CHANGELOG.md` style from `semantic-release`~~
- [x] ~~Remove `python` commands from `package.json`~~
- [x] ~~Combine `scripts/setup.ba.sh` with `install.ba.sh`~~

### CLI cmds in requirements.pipx.txt

Expand Down
5 changes: 4 additions & 1 deletion scripts/install.ba.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,11 @@ echo "Script directory: ${scripts_path}"

set -x

# Upgrades top-level dependencies, like pipx
bash ${scripts_path}/pip/upgrade.ba.sh

# pipx installs CLI executables, like poetry
bash ${scripts_path}/setup.ba.sh
bash ${scripts_path}/pipx/install.ba.sh

# pip installs dependencies
bash ${scripts_path}/pip/install.ba.sh ${target_config}
Expand Down

0 comments on commit 0e9ba2d

Please sign in to comment.