Application submission management clarity #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #781 +/- ##
==========================================
- Coverage 72.67% 72.64% -0.04%
==========================================
Files 32 32
Lines 7078 7091 +13
==========================================
+ Hits 5144 5151 +7
- Misses 1934 1940 +6 ☔ View full report in Codecov by Sentry. |
Comment on lines
+6625
to
+6632
| if skip["pending"]: | ||
| skip_msg += f" {skip['pending']} still marked as pending" | ||
| if skip["no_reason"]: | ||
| skip_msg += f" {skip['no_reason']} have no reason provided" | ||
| return Response( | ||
| { | ||
| "detail": f"{dry_run_msg} emails to {n} people, " | ||
| f"skipping {skip} due to one of (already notified, no reason, no email)" | ||
| f"{skip_msg if skip_msg else ''}", |
There was a problem hiding this comment.
Not sure how this message shows up on the frontend (guessing it's a toast), but are these going to render as on the same line? Might be good to add newlines (or some sort of delimiter) between the messages if so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some QoL improvements to the application submission management flow for club officers, aiming at reducing user error and increasing clarity for the application decision sending process:
/applicationroute returns a proper X not found screen instead of an empty one