Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes to fix issues running the Spacewalk client in Kubernetes #519

Merged
merged 28 commits into from
May 24, 2024
Merged

Add changes to fix issues running the Spacewalk client in Kubernetes #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3ab512a
Change/remove `backoff::retry()` usage in runner
ebma Apr 18, 2024
2e6cbc4
Remove `backoff` from error.rs
ebma May 2, 2024
8132db0
Manually implement backoff behaviour
ebma May 2, 2024
4c52142
Merge branch 'main' into connection-issues-investigation
ebma May 7, 2024
88c108e
Fix build error
ebma May 7, 2024
e92bb7c
Formatting
ebma May 7, 2024
60d63e9
Refactor error messages
ebma May 7, 2024
a6fe253
Restore original logic with max retry interval
ebma May 8, 2024
bc4c6fc
Remove import
ebma May 8, 2024
32b8d0a
Run `cargo +nightly-2024-02-09 fmt --all`
ebma May 8, 2024
93c9bb2
Run cargo fmt with nightly
ebma May 8, 2024
8784c23
Add logic to reopen the runner websocket
ebma May 13, 2024
e24496d
Add debug logs
ebma May 13, 2024
d553ed7
Fix compile issues
ebma May 13, 2024
585c267
Add test for the backoff/retry logic
ebma May 15, 2024
2bf4dc2
Simplify retry logic
ebma May 15, 2024
8c2f5cb
Use test for both
ebma May 15, 2024
11504ed
Remove unfinished test case and refactor
ebma May 15, 2024
110dceb
fix trailing semicolons
b-yap May 16, 2024
4f3fed9
Refactor error handling around `try_get_release()`
ebma May 17, 2024
c9dcd4a
Merge branch 'main' into connection-issues-investigation
ebma May 22, 2024
18d8746
Remove patch statement for `ahash` again
ebma May 22, 2024
4e8b516
Remove patch statement for `ahash` again
ebma May 22, 2024
287116c
Replace references to `nightly-02-09` with `nightly-04-18`
ebma May 22, 2024
1409157
Don't log message for each retry
ebma May 22, 2024
64c7c9a
Change `max-parallel` to `2`
ebma May 22, 2024
cabd7f0
Add some 'allow' statements for clippy
ebma May 23, 2024
dc2407f
revert version to 2024-02-09
b-yap May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
max-parallel: 1
matrix:
os: [ ubuntu-latest, macos-latest ]
rust: [stable, nightly]
rust: [ stable, nightly ]
include:
- os: ubuntu-latest
sccache-path: /home/runner/.cache/sccache
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:

- name: Setup nightly Rust toolchain
if: matrix.rust == 'nightly'
uses: dtolnay/rust-toolchain@nightly
uses: dtolnay/rust-toolchain@nightly
with:
toolchain: nightly-2024-02-09
components: rustfmt, clippy
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ name: continuous-integration-main
jobs:
ci:
strategy:
max-parallel: 1
max-parallel: 2
matrix:
rust: [stable, nightly]
rust: [ stable, nightly ]
runs-on: ubuntu-20.04
env:
RUST_BACKTRACE: full
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:

- name: Setup nightly Rust toolchain
if: matrix.rust == 'nightly'
uses: dtolnay/rust-toolchain@nightly
uses: dtolnay/rust-toolchain@nightly
with:
toolchain: nightly-2024-02-09
components: rustfmt, clippy
Expand Down
Loading
Loading