'configure' import fail in test_production.py #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now hardcoded in utils.py
- Name, description and URL changed. - Removed extra dependencies.
- In case we ever need to refresh the hardcoded one.
- Very small and rare module.
- The ones inherited from certauth - Now the setup takes the dependencies from requirements.txt
- Removed the BatchProductDetails API, not free. - Added wrapper to use it from KiCost.
- To check for dir, not file
- Arguments are tuples, not lists
- Now the default is to cache results for 24 hours - Can be configured using DIGIKEY_CACHE_TTL - Cache can be "persistent" using a negative value - The cache can be supressed using 0
- Routed to debug - Also made oauth2 logger configurable
- Unless we are debugging
- Useful for debug.
- Nothing from the environment - This is because KiCost is centralizing the config
- Removed the cache implementation
- Using just an object, not multiple inheritance
- Also fixed missing shebang
- Also changed the e-mail to match the signature
- Do not cache empty results - Avoid trying to access them
- Used things that no longer exist - Implemented the configuration logic in tools/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed the README, but the test execution failed on 'configure' import.
python3 test_production.py
Traceback (most recent call last):
File "/home/michael/projects/kicost-digikey-api-v3/test_production.py", line 1, in
from kicost_digikey_api_v3 import by_digikey_pn, by_keyword, by_manf_pn, configure
ImportError: cannot import name 'configure' from 'kicost_digikey_api_v3' (/home/michael/projects/kicost-digikey-api-v3/kicost_digikey_api_v3/init.py)