Ranged Integers

[IBims1NicerTobi]

Close #28

[IBims1NicerTobi]

Add test cases

[IBims1NicerTobi]

Add types to in code values / constants

[IBims1NicerTobi]

Cast module

[IBims1NicerTobi]

Fix this:

Error: Failed to Typecheck Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) = Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) + Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_5)] })
    ╭─[/home/tobias/.sus/0.2.0-devel/std/util.sus:91:11]
    │
 91 │        value = value + 1
    │                ────┬────
    │                    ╰────── Failed to Typecheck Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) = Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) + Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_5)] })
────╯

[VonTum]

Fix this:

Error: Failed to Typecheck Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) = Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) + Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_5)] })
    ╭─[/home/tobias/.sus/0.2.0-devel/std/util.sus:91:11]
    │
 91 │        value = value + 1
    │                ────┬────
    │                    ╰────── Failed to Typecheck Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) = Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_1)] }) + Named(ConcreteGlobalReference { id: type_1, template_args: [Unknown(concrete_type_variable_5)] })
────╯

Well it seems that that on its own should never typecheck. Rather either the user should specify a cast, or add a % max_val

[IBims1NicerTobi]

Add lower bound to all ints too.

[VonTum]

The semantics of MIN and MAX should be:
MIN is inclusive, MAX is exclusive.

So int #(MIN: 3, MAX: 16) can have a value from 3-15 inclusive.

It makes for better ergonomics. (powers of 2, clog2, etc)

[VonTum]

Oh also, BitsToInt will need to be expressed from the source bits, as we can't really make any statements about the value of these bits.

We'll need a pow2 #(V) for that. I might add that if I get around to it

[VonTum]

Looks good, does it appear to behave correctly as you use it?

[VonTum]

We'll also need UnaryOpTypecheckConstraint

[IBims1NicerTobi]

What exactly do the UnaryOperator::Sum/UnaryOperator::Product do with arrays?

[VonTum]

Well, the sum of an array has as its bounds Size * MIN .. Size * (MAX-1)+1, as for the product, it should have bounds MIN ^ Size, (MAX - 1) ^ Size + 1

[VonTum]

Though this kind of intersects with #74 we'll have to figure out a better design for such large unary reductions at some point

[VonTum]

Actually, thinking further about it, we should make both IntToBits and BitsToInt have a template argument in the number of bits. And then have #75 Deal with the integer cast

[IBims1NicerTobi]

Add a compiler intrinsic for casting ints
Change the output of codegen

[VonTum]

Div & Modulo should error on is_zero

[VonTum]

Update Value::get_type to properly handle sized ints

[VonTum]

Thorough analysis of the cases, well done!

[VonTum]

I recently added FlatAlloc::cast_to_array and FlatAlloc::map_to_array. (https://github.com/pc2/sus-compiler/blob/master/src/alloc.rs#L622-L632) That would make this code a bit nicer

[VonTum]

As an example of it used: https://github.com/pc2/sus-compiler/blob/master/src/instantiation/execute.rs#L272

Thinking about it, arg.unwrap_value().unwrap_integer() is used a lot in this kind of code, perhaps even adding a get_integer_template_args_array method to ConcreteGlobalReference would make code more compact still