Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngh0
requested changes
Feb 24, 2024
src/main/java/com/example/parking/domain/review/PrivateImageStorage.java
Outdated
Show resolved
Hide resolved
src/test/java/com/example/parking/application/review/ReviewServiceTest.java
Outdated
Show resolved
Hide resolved
jundonghyuk
requested changes
Feb 26, 2024
Comment on lines
33
to
40
| @ManyToOne(fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "parking_id", nullable = false) | ||
| private Parking parking; | ||
|
|
||
| @ManyToOne(fetch = FetchType.LAZY) | ||
| @JoinColumn(name = "reviewer_id", nullable = false) | ||
| private Member reviewer; | ||
|
|
There was a problem hiding this comment.
리뷰가 Parking과 reviewer 자체를 알아야 할 필요가 있을까요 ?
id만 갖고있어도 될 것 같은데, 너무 커플링이 되어있는것같아서 여쭙습니다..!
src/test/java/com/example/parking/application/review/ReviewServiceTest.java
Outdated
Show resolved
Hide resolved
|
jundonghyuk
approved these changes
Mar 12, 2024
# Conflicts: # .gitignore # src/main/java/com/example/parking/domain/member/MemberRepository.java # src/main/java/com/example/parking/domain/parking/Parking.java # src/main/resources/application.properties # src/test/java/com/example/parking/auth/MemberSessionRepositoryTest.java
Test Results115 tests 115 ✅ 2s ⏱️ Results for commit de1386e. |
youngh0
added a commit
that referenced
this pull request
Mar 12, 2024
* feat: 즐겨찾기 엔티티 생성 * feat: 컴파일 에러 수정 * feat: 즐겨찾기 Repository 구현 * feat: 즐겨찾기 dto 구현 * feat: 즐겨찾기 service 구현 * feat: 즐겨찾기 controller 구현 * feat: memberId, parkingId 값 객체 생성 * Create ci.yml * fix: 없어진 괄호 수정 * fix: 테스트용 설정 파일 추가 * Update ci.yml PR 코멘트는 pr일때만 보내도록 변경 * Update ci.yml * Update ci.yml * Update ci.yml * Update ci.yml * Feat/#19 리뷰 관리 기능 구현 (#33) * Refactor: DB <-> Application 간 데이터 변환하는 컨버터 위치 수정 * feat: 이미지 저장할 패키지 추가 * fix: 오류나는 패키지 구조 변경 * feat: 리뷰에서 선택할 수 있는 글 생성 * feat: 이미지 저장하는 기능 구현 * feat: 리뷰 작성하는 기능 구현 * feat: 리뷰 컨트롤러 작성(테스트용) * test: mysql 도 돌릴 수 있도록 수정 * gitignroe 추가 * properties 추가 * test: 안쓰는 어노테이션 제거 * refactor: 이미지 제거 * refactor: 연관관계 ID 참조로 변경 * feat: 주차장 조회 기능 구현 * refactor: 패키지명 변경 common -> support * refactor: 기본 생성자 접근자 변경 * refactor: Convert 어노테이션 필드에 붙이도록 변경 * refactor: createdAt 필드 변경 * ci test * ci test2 * refactor: 이미지 관련 파일 삭제 * fix: conflict 해결 * feat: 즐겨찾기 엔티티 생성 * feat: 컴파일 에러 수정 * feat: 즐겨찾기 Repository 구현 * feat: 즐겨찾기 dto 구현 * feat: 즐겨찾기 service 구현 * feat: 즐겨찾기 controller 구현 * feat: memberId, parkingId 값 객체 생성 * feat: api 스펙 변경 * feat: association 적용 --------- Co-authored-by: LeeGeonHo <zx00018@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍관련 이슈
🤔세부 내용
todo
🫵리뷰 중점사항
MemberRepositoryFake 객체 만든다고JpaRepository에서Repository로 변경했는데 괜찮을까여?