Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Change sqlite test query string values to single quotes #61000

Merged
merged 1 commit into from
Feb 24, 2025
Merged

TST: Change sqlite test query string values to single quotes #61000

merged 1 commit into from
Feb 24, 2025

Conversation

mroeschke
Copy link
Member

xref https://github.com/pandas-dev/pandas/actions/runs/13505086719/job/37732738398

Might be a new failure interaction with sqlite3 and sqlite 3.49 being released recently https://www.sqlite.org/changes.html, but if this query is backward compatible we might as well use this form.

closes #60989

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite IO SQL to_sql, read_sql, read_sql_query labels Feb 24, 2025
@mroeschke mroeschke added this to the 2.3 milestone Feb 24, 2025
@mroeschke
Copy link
Member Author

Since this is passing on sqlite 3.48 (tested on ubuntu-arm) and 3.49 (tested on ubuntu-(x86)), going to merge to get to green

@mroeschke mroeschke merged commit d575eea into pandas-dev:main Feb 24, 2025
46 checks passed
@mroeschke mroeschke deleted the ci/sqllite branch February 24, 2025 21:39
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Feb 24, 2025
@mroeschke @meeseeksmachine
Backport PR pandas-dev#61000: TST: Change sqlite test query string va…
2a8b0f8 
…lues to single quotes
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 24, 2025
Merged
mroeschke added a commit that referenced this pull request Feb 24, 2025
@meeseeksmachine @mroeschke
Backport PR #61000 on branch 2.3.x (TST: Change sqlite test query str…
3ee2ffe 
…ing values to single quotes) (#61001)

Backport PR #61000: TST: Change sqlite test query string values to single quotes

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.3
Development

Successfully merging this pull request may close these issues.

BUG: Urgent - All PR's are getting deployment errors in git pipeline
1 participant
@mroeschke