-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Groupby.sum, DataFrame.sum and Series.sum for object type should be NA instead of 0 for all-nan values #60458
base: main
Are you sure you want to change the base?
Conversation
snitish
commented
Dec 1, 2024
•
edited
Loading
edited
- partly addresses BUG/API: sum of a string column with all-NaN or empty #60229
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
- Added type annotations to new arguments/methods/functions.
- Added note to whatsnew/v3.0.0.rst
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
@rhshadrach sure I'd be happy to. There was some debate on the original thread on whether the default sum value for |
For object dtype, I'm only seeing support for NA in that thread. Am I missing any contrary opinions? The only hesitation I see is @Dr-Irv on how this impacts users, but I do not see an easy deprecation path and I am comfortable with listing this in the breaking changes for 3.0 When I say NA here, I mean "the NA value for the given dtype". For object dtype, the NA value is |
Thanks for approving, @WillAyd. This PR still doesn't address the issue for |