updated str_is_numeric(), allows floats

pandas-dev · Feb 18, 2025 · bd25234 · bd25234
1 parent 6bcd303
commit bd25234
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/pandas/core/strings/base.py b/pandas/core/strings/base.py
@@ -6,7 +6,7 @@
     Literal,
 )
 
-from pandas._libs import lib
+#from pandas._libs import lib
 
 if TYPE_CHECKING:
     from collections.abc import (
@@ -93,7 +93,7 @@ def _str_match(
         pat: str,
         case: bool = True,
         flags: int = 0,
-        na: Scalar | lib.NoDefault = lib.no_default,
+        #na: Scalar | lib.NoDefault = lib.no_default,
     ):
         pass
 
@@ -103,7 +103,7 @@ def _str_fullmatch(
         pat: str | re.Pattern,
         case: bool = True,
         flags: int = 0,
-        na: Scalar | lib.NoDefault = lib.no_default,
+        #na: Scalar | lib.NoDefault = lib.no_default,
     ):
         pass
 
@@ -197,7 +197,11 @@ def _str_islower(self):
 
     @abc.abstractmethod
     def _str_isnumeric(self):
-        pass
+        try:
+            float(self)
+            return True
+        except ValueError:
+            return False
 
     @abc.abstractmethod
     def _str_isspace(self):